Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Page with BrowsingContext #11031

Closed
jdm opened this issue May 5, 2016 · 1 comment
Closed

Replace Page with BrowsingContext #11031

jdm opened this issue May 5, 2016 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented May 5, 2016

As far as I know their purpose is identical. Page is our own wishy-washy concept, it's an Rc<T> that contains JS-owned data (dangerous!), and it basically delegates to the browsing context anyways.
#5236

@cbrewster
Copy link
Member

@cbrewster cbrewster commented May 5, 2016

I am working on this

@cbrewster cbrewster added the C-assigned label May 5, 2016
@cbrewster cbrewster self-assigned this May 5, 2016
bors-servo added a commit that referenced this issue May 6, 2016
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
@cbrewster cbrewster mentioned this issue May 6, 2016
18 of 24 tasks complete
bors-servo added a commit that referenced this issue May 6, 2016
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 6, 2016
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 7, 2016
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 7, 2016
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 12, 2016
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.