Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Page with BrowsingContext #11031

Closed
jdm opened this issue May 5, 2016 · 1 comment
Closed

Replace Page with BrowsingContext #11031

jdm opened this issue May 5, 2016 · 1 comment
Assignees
@cbrewster
Labels
A-content/script Related to the script thread C-assigned There is someone working on resolving the issue C-has-open-pr There is a PR open that resolves the issue I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.

Comments

@jdm
Copy link
Member

jdm commented May 5, 2016

As far as I know their purpose is identical. Page is our own wishy-washy concept, it's an Rc<T> that contains JS-owned data (dangerous!), and it basically delegates to the browsing context anyways.
#5236
@jdm jdm added I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring. A-content/script Related to the script thread labels May 5, 2016
@cbrewster
Copy link
Contributor

I am working on this

@cbrewster cbrewster added the C-assigned There is someone working on resolving the issue label May 5, 2016
@cbrewster cbrewster self-assigned this May 5, 2016
@cbrewster cbrewster mentioned this issue May 6, 2016
Merged
bors-servo pushed a commit that referenced this issue May 6, 2016
Auto merge of #11044 - ConnorGBrewster:page_to_browsing_context, r=<try>
b7bcc25 
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
@cbrewster cbrewster mentioned this issue May 6, 2016
Open
24 tasks
bors-servo pushed a commit that referenced this issue May 6, 2016
Auto merge of #11044 - ConnorGBrewster:page_to_browsing_context, r=<try>
fa7fd35 
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 6, 2016
Auto merge of #11044 - ConnorGBrewster:page_to_browsing_context, r=<try>
834c782 
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 7, 2016
Auto merge of #11044 - ConnorGBrewster:page_to_browsing_context, r=<try>
b492776 
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 7, 2016
Auto merge of #11044 - ConnorGBrewster:page_to_browsing_context, r=<try>
8891e38 
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
@cbrewster cbrewster added the C-has-open-pr There is a PR open that resolves the issue label May 7, 2016
bors-servo pushed a commit that referenced this issue May 12, 2016
Auto merge of #11044 - ConnorGBrewster:page_to_browsing_context, r=jdm
685dc99 
Combine Page into BrowsingContext

Fixes #11031.

`Page` and `BrowsingContext` have similar use cases and we decided it would be best to join the two.

This is the ground work for actually using session history in the `BrowsingContext` to implement the History API.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11044)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbrewster cbrewster

Labels
A-content/script Related to the script thread C-assigned There is someone working on resolving the issue C-has-open-pr There is a PR open that resolves the issue I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @cbrewster