-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JS_NewStringCopyN for the representation of interface objects #11188
Conversation
Heads up! This PR modifies the following files:
|
r? @Ms2ger |
New code was committed to pull request. |
@@ -1993,17 +1993,16 @@ def define(self): | |||
args = { | |||
"constructorBehavior": constructorBehavior, | |||
"id": name, | |||
"representation": str_to_const_array("function %s() {\\n [native code]\\n}" % name), | |||
"representation": "b\"function %s() {\\n [native code]\\n}\"" % name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use single quotes for the python string to avoid escaping the Rust quotes; r+ with that
This removes the need for the final null byte and we can make NonCallbackInterfaceObjectClass::new safe again I guess.
New code was committed to pull request. |
@bors-servo r=Ms2ger |
📌 Commit 4af3e90 has been approved by |
Use JS_NewStringCopyN for the representation of interface objects This removes the need for the final null byte and we can make NonCallbackInterfaceObjectClass::new safe again I guess. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11188) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows |
This removes the need for the final null byte and we can make NonCallbackInterfaceObjectClass::new safe again I guess.
This change is