Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement [Unscopable] #11583

Closed
nox opened this issue Jun 3, 2016 · 5 comments
Closed

Implement [Unscopable] #11583

nox opened this issue Jun 3, 2016 · 5 comments
Assignees
@nox
Labels
A-content/bindings The DOM bindings A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue

Comments

@nox
Copy link
Contributor

nox commented Jun 3, 2016

Latest smup made that implementable.

http://heycam.github.io/webidl/#Unscopable
@nox nox added A-content/dom Interacting with the DOM from web content A-content/bindings The DOM bindings labels Jun 3, 2016
@nox
Copy link
Contributor Author

nox commented Jun 4, 2016

The test in tests/wpt/web-platform-tests/dom/nodes/remove-unscopable.html is related.

@nox
Copy link
Contributor Author

nox commented Jun 4, 2016

Blocks #2185.

@nox
Copy link
Contributor Author

nox commented Jun 5, 2016

I wrote something but I think I have some bad news: the C++ code in Gecko uses SYMBOL_TO_JSID, which we apparently don't bind. :/

@nox
Copy link
Contributor Author

nox commented Jun 5, 2016

Oh I see, it's an inline symbol. I will reimplement it in rust-mozjs.

nox added a commit to nox/servo that referenced this issue Jun 5, 2016
@nox
Implement [Unscopable] (fixes servo#11583)
b5a81d5
@nox
Copy link
Contributor Author

nox commented Jun 5, 2016

Blocked on servo/rust-mozjs#268.

@nox nox added S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. C-assigned There is someone working on resolving the issue labels Jun 5, 2016
@nox nox self-assigned this Jun 5, 2016
nox added a commit to nox/servo that referenced this issue Jun 5, 2016
@nox
Implement [Unscopable] (fixes servo#11583)
64c1e00
@nox nox removed the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Jun 5, 2016
bors-servo pushed a commit that referenced this issue Jun 5, 2016
Auto merge of #11620 - nox:unscopable, r=<try>
36360b9 
Implement [Unscopable] (fixes #11583)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11620)
<!-- Reviewable:end -->
nox added a commit to nox/servo that referenced this issue Jun 7, 2016
@nox
Implement [Unscopable] (fixes servo#11583)
2419cb9
bors-servo pushed a commit that referenced this issue Jun 7, 2016
Auto merge of #11620 - nox:unscopable, r=Ms2ger
f56848a 
Implement [Unscopable] (fixes #11583)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11620)
<!-- Reviewable:end -->
@farodin91 farodin91 mentioned this issue Jun 9, 2016
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nox nox

Labels
A-content/bindings The DOM bindings A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nox