Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compositing: Only recomposite after a scroll if layers actually moved, and fix the jerky scrolling "pops" during flings on Mac. #11949

Merged
merged 1 commit into from Jun 30, 2016

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jun 30, 2016

See the comments in compositor.rs for more details.

Fixes #11658.


This change is Reviewable

and fix the jerky scrolling "pops" during flings on Mac.

See the comments in compositor.rs for more details.

Requires servo/webrender#302 and servo/webrender_traits#64.
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 30, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jun 30, 2016

From #11938

r? @glennw

@highfive highfive assigned glennw and unassigned metajack Jun 30, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jun 30, 2016

@bors-servo r=glennw

(On IRC)

@bors-servo
Copy link
Contributor

📌 Commit 90e970a has been approved by glennw

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 30, 2016
bors-servo pushed a commit that referenced this pull request Jun 30, 2016
compositing: Only recomposite after a scroll if layers actually moved, and fix the jerky scrolling "pops" during flings on Mac.

See the comments in compositor.rs for more details.

Fixes #11658.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11949)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 90e970a with merge 26d2ee6...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 90e970a into master Jun 30, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 30, 2016
@Ms2ger Ms2ger deleted the wr branch June 30, 2016 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants