Only send new scroll frames to the compositor if a scroll event actually resulted in motion, and fix some overscroll problems. #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.001 is way too small and results in lots of unnecessary frames of bounce animation.
Before, the animation could incorrectly restart if a fling lasted longer than the bounce animation took to run.
resulted in motion. Requires servo/webrender_traits#64.
pcwalton
added a commit
to pcwalton/servo
that referenced
this pull request
Jun 29, 2016
and fix the jerky scrolling "pops" during flings on Mac. See the comments in compositor.rs for more details. Requires servo/webrender#302 and servo/webrender_traits#64.
|
@pcwalton This part looks fine once the other bits are reviewed. |
|
@bors-servo: r=glennw |
|
📌 Commit 3aec09d has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 30, 2016
Only send new scroll frames to the compositor if a scroll event actually resulted in motion, and fix some overscroll problems. Requires servo/webrender_traits#64. r? @glennw
Ms2ger
pushed a commit
to servo/servo
that referenced
this pull request
Jun 30, 2016
and fix the jerky scrolling "pops" during flings on Mac. See the comments in compositor.rs for more details. Requires servo/webrender#302 and servo/webrender_traits#64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires servo/webrender_traits#64.
r? @glennw