Add support for background-repeat: space and round #13331

mrobinson · 2016-09-20T09:54:17Z

Add support for new background-repeat modes and upgrade Euclid, which now has support for basic arithmetic with Size2D.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #__ (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because _____

This adds support for more background-repeat modes using the legacy
rasterization backend.

This change is

highfive · 2016-09-20T09:54:24Z

Heads up! This PR modifies the following files:

@bholley: components/style/properties/longhand/background.mako.rs

jdm · 2016-09-20T13:47:07Z

error[E0004]: non-exhaustive patterns: `space` and `round` not covered
    --> /home/travis/build/servo/servo/target/debug/build/style-b398ea74b908472c/out/gecko_properties.rs:3222:42
     |
3222 |         let (repeat_x, repeat_y) = match servo {
     |                                          ^^^^^ patterns `space` and `round` not covered
error: aborting due to previous error
error: Could not compile `style`.
To learn more, run the command again with --verbose.
The command "./mach test-geckolib" exited with 101.

mrobinson · 2016-09-21T09:31:57Z

Thanks. I've updated the PR, so hopefully this build error is fixed.

glennw · 2016-09-21T09:50:29Z

@mrobinson I landed a WR update with dummy settings for the tile spacing API change here https://github.com/servo/servo/pull/13309/files today. So it should be fine to update this PR to pass the new values through to WR if you like.

mrobinson · 2016-09-21T10:23:04Z

@glennw Okay. I've updated the PR. WebRender support for background-repeat space should now be included.

mrobinson · 2016-09-21T11:16:00Z

I think the Windows build failure is #13340.

glennw · 2016-09-21T19:50:14Z

r=me for the display list parts and cargo.lock. Someone else should check over the parser / geckolib bits. r? @emilio or @SimonSapin

emilio · 2016-09-21T23:42:58Z

r=me for the gecko changes.

@bors-servo: r=glennw,emilio

Thanks for this Martin!

bors-servo · 2016-09-21T23:42:59Z

📌 Commit ccd43d6 has been approved by glennw,emilio

emilio · 2016-09-21T23:45:55Z

components/layout/fragment.rs

+                             image_size: Au) {
+        if *size == Au::new(0) || image_size == Au::new(0) {
+            *position = Au::new(0);
+            *size =Au::new(0);


nit: Minor formatting nit, there's a space missing here and in the previous function. Also, I think the usual way we write an empty Au value is Au(0) directly, though not sure if this has changed recently (please disregard it if that's the case).

Please fix these nits if any test fails, or otherwise in a followup, thanks!

Thanks. These are fixed now.

bors-servo · 2016-09-22T04:01:55Z

⌛ Testing commit ccd43d6 with merge e7d2f03...

Add support for background-repeat: space and round  Add support for new background-repeat modes and upgrade Euclid, which now has support for basic arithmetic with Size2D. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____  This adds support for more background-repeat modes using the legacy rasterization backend.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13331)

bors-servo · 2016-09-22T05:07:22Z

💔 Test failed - linux-rel

highfive · 2016-09-22T05:07:26Z

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform3d-translatez-001.htm
  └   → /css-transforms-1_dev/html/transform3d-translatez-001.htm 902d90a8d198625335e738587fdfe81dcc90392d
/css-transforms-1_dev/html/reference/transform3d-translatez-ref.htm b14318ccfd8a59b7b249d41521e178d617678823
Testing 902d90a8d198625335e738587fdfe81dcc90392d == b14318ccfd8a59b7b249d41521e178d617678823
/css-transforms-1_dev/html/transform3d-translatez-001.htm 902d90a8d198625335e738587fdfe81dcc90392d
/css-transforms-1_dev/html/reference/transform3d-translatez-notref.htm 902d90a8d198625335e738587fdfe81dcc90392d
Testing 902d90a8d198625335e738587fdfe81dcc90392d != 902d90a8d198625335e738587fdfe81dcc90392d

bors-servo · 2016-09-22T11:18:58Z

📌 Commit c571689 has been approved by emilio

bors-servo · 2016-09-22T11:19:31Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Update Cargo and Rust #13351

bors-servo · 2016-09-22T11:19:31Z

📌 Commit c571689 has been approved by emilio

This adds support for more background-repeat modes using the legacy rendering backend.

mrobinson · 2016-09-22T11:21:49Z

@bors-servo r=emilio

bors-servo · 2016-09-22T11:21:50Z

📌 Commit 68ae97f has been approved by emilio

bors-servo · 2016-09-22T11:37:11Z

⌛ Testing commit 68ae97f with merge efdd94a...

Add support for background-repeat: space and round  Add support for new background-repeat modes and upgrade Euclid, which now has support for basic arithmetic with Size2D. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____  This adds support for more background-repeat modes using the legacy rasterization backend.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13331)

bors-servo · 2016-09-22T12:47:47Z

💔 Test failed - mac-rel-wpt

jdm · 2016-09-22T13:32:47Z

@bors-servo: retry

Intermittent timeout of /_mozilla/webgl/conformance-1.0.3/conformance/attribs/gl-matrix-attributes.html #13359

bors-servo · 2016-09-22T15:01:30Z

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

bors-servo · 2016-09-22T16:05:52Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

highfive assigned nox Sep 20, 2016

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 20, 2016

mrobinson force-pushed the background-repeat branch from 43d88e3 to 62ab2d9 Compare September 21, 2016 09:31

mrobinson force-pushed the background-repeat branch from 62ab2d9 to ccd43d6 Compare September 21, 2016 10:21

highfive assigned emilio and unassigned nox Sep 21, 2016

highfive assigned glennw and unassigned emilio Sep 21, 2016

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 21, 2016

emilio reviewed Sep 21, 2016

View reviewed changes

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 22, 2016

mrobinson force-pushed the background-repeat branch from ccd43d6 to c571689 Compare September 22, 2016 11:18

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 22, 2016

highfive assigned emilio and unassigned glennw Sep 22, 2016

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 22, 2016

Add support for background-repeat: space and round

68ae97f

This adds support for more background-repeat modes using the legacy rendering backend.

mrobinson force-pushed the background-repeat branch from c571689 to 68ae97f Compare September 22, 2016 11:21

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 22, 2016

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 22, 2016

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 22, 2016

bors-servo merged commit 68ae97f into servo:master Sep 22, 2016

bors-servo mentioned this pull request Sep 22, 2016

Merge most of geckolib into style #13372

Merged

glennw mentioned this pull request Sep 23, 2016

Add support for background-repeat: space; servo/webrender#363

Closed

mrobinson deleted the background-repeat branch October 17, 2016 13:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for background-repeat: space and round #13331

Add support for background-repeat: space and round #13331

mrobinson commented Sep 20, 2016 •

edited by jdm

Loading

highfive commented Sep 20, 2016

jdm commented Sep 20, 2016 •

edited

Loading

mrobinson commented Sep 21, 2016

glennw commented Sep 21, 2016

mrobinson commented Sep 21, 2016

mrobinson commented Sep 21, 2016

glennw commented Sep 21, 2016

emilio commented Sep 21, 2016

bors-servo commented Sep 21, 2016

emilio Sep 21, 2016

mrobinson Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

highfive commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

mrobinson commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

jdm commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

Add support for background-repeat: space and round #13331

Add support for background-repeat: space and round #13331

Conversation

mrobinson commented Sep 20, 2016 • edited by jdm Loading

highfive commented Sep 20, 2016

jdm commented Sep 20, 2016 • edited Loading

mrobinson commented Sep 21, 2016

glennw commented Sep 21, 2016

mrobinson commented Sep 21, 2016

mrobinson commented Sep 21, 2016

glennw commented Sep 21, 2016

emilio commented Sep 21, 2016

bors-servo commented Sep 21, 2016

emilio Sep 21, 2016

Choose a reason for hiding this comment

mrobinson Sep 22, 2016

Choose a reason for hiding this comment

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

highfive commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

mrobinson commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

jdm commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

mrobinson commented Sep 20, 2016 •

edited by jdm

Loading

jdm commented Sep 20, 2016 •

edited

Loading