Implement support for equality constraints in media queries #13670
Labels
A-content/css
Interacting with CSS from web content (parsing, serializing, introspection)
Comments
Ms2ger
added
the
A-content/css
|
can I try this one? |
|
Sure. Feel free to ask any questions here. |
|
Sorry I've been busy with servo/webrender#465 lately, I still plan on picking this one up later down the road however. If someone else has a burning desire to take it one, please let me know in the meantime... |
5 tasks
bors-servo
pushed a commit
that referenced
this issue
Nov 26, 2016
implement support for the width query <!-- Please describe your changes on the following line: --> implement support for the `width` media query --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix ##13670 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14192) <!-- Reviewable:end -->
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Feb 4, 2017
…rzian:support_equality_constraints); r=emilio <!-- Please describe your changes on the following line: --> implement support for the `width` media query --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #servo/servo#13670 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: bcc76f8a58f2ebe3886d16ff3eebbe68e3debf6c
|
Media queries for |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 1, 2019
…rzian:support_equality_constraints); r=emilio <!-- Please describe your changes on the following line: --> implement support for the `width` media query --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #servo/servo#13670 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: bcc76f8a58f2ebe3886d16ff3eebbe68e3debf6c UltraBlame original commit: 41fd3e16f183603a64c9d57fb5f0509f26a0d5d1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 1, 2019
…rzian:support_equality_constraints); r=emilio <!-- Please describe your changes on the following line: --> implement support for the `width` media query --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #servo/servo#13670 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: bcc76f8a58f2ebe3886d16ff3eebbe68e3debf6c UltraBlame original commit: 41fd3e16f183603a64c9d57fb5f0509f26a0d5d1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 1, 2019
…rzian:support_equality_constraints); r=emilio <!-- Please describe your changes on the following line: --> implement support for the `width` media query --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #servo/servo#13670 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: bcc76f8a58f2ebe3886d16ff3eebbe68e3debf6c UltraBlame original commit: 41fd3e16f183603a64c9d57fb5f0509f26a0d5d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, the
widthquery: https://drafts.csswg.org/mediaqueries/#width. There's a test intests/wpt/mozilla/tests/css/matchMedia.html(added in #13453) that should pass with that fixed.Code is in
components/style/media_queries.rs.The text was updated successfully, but these errors were encountered: