New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement blob url support in the fetch stack. #13750
Conversation
Heads up! This PR modifies the following files:
|
@bors-servo try |
Implement blob url support in the fetch stack.
8ce01a9
to
699287e
Compare
@bors-servo try |
Implement blob url support in the fetch stack. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13750) <!-- Reviewable:end -->
💔 Test failed - linux-rel-wpt |
r? @Manishearth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be passing tests here, if not add some.
let _ = sender.send(Err(FileManagerThreadError::BlobURLStoreError(e))); | ||
} | ||
}) | ||
if let Err(e) = store.try_read_file(&sender, id, check_url_validity, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file I/O is slow too, shouldn't we spawn a thread for that? ditto for promotememory
@@ -119,3 +120,71 @@ fn load_blob<UI: 'static + UIProvider> | |||
send_error(load_data.url.clone(), format_err, start_chan); | |||
} | |||
} | |||
|
|||
// TODO: make async. | |||
pub fn load_blob_sync<UI: 'static + UIProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spec link
The spawned threads remain for select_file and select_files, as those may need to wait indefinitely for the user's response.
@bors-servo r=Manishearth |
📌 Commit 6eaef7c has been approved by |
⌛ Testing commit 6eaef7c with merge d692cf1... |
Implement blob url support in the fetch stack. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13750) <!-- Reviewable:end -->
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
This change is