Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a missing newline. #14046

Merged
merged 1 commit into from Nov 4, 2016
Merged

Add a missing newline. #14046

merged 1 commit into from Nov 4, 2016

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 3, 2016 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

highfive commented Nov 3, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/codegen/CodegenRust.py
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py

@highfive
Copy link

highfive commented Nov 3, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 3, 2016
@jdm
Copy link
Member

jdm commented Nov 3, 2016

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 25d9d2b has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 3, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 25d9d2b with merge 97e205c...

bors-servo pushed a commit that referenced this pull request Nov 4, 2016
Auto merge of #14046 - servo:ws-callback, r=jdm
97e205c 
Add a missing newline.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14046)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit 25d9d2b into master Nov 4, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 4, 2016
@Ms2ger Ms2ger deleted the ws-callback branch November 4, 2016 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ms2ger @highfive @jdm @bors-servo