Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privatize most of the net crate. #14063

Merged
merged 3 commits into from Nov 6, 2016
Merged

Privatize most of the net crate. #14063

merged 3 commits into from Nov 6, 2016

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 4, 2016 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

highfive commented Nov 4, 2016

Heads up! This PR modifies the following files:

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 4, 2016
@nox
Copy link
Contributor

nox commented Nov 4, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit d239980 has been approved by nox

@highfive highfive assigned nox and unassigned Manishearth Nov 4, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 4, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit d239980 with merge c1ad922...

bors-servo pushed a commit that referenced this pull request Nov 4, 2016
Auto merge of #14063 - servo:privatize-net, r=nox
c1ad922 
Privatize most of the net crate.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14063)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 4, 2016
@KiChjang
Copy link
Contributor

KiChjang commented Nov 4, 2016

Fails tidy:

./tests/unit/net/http_loader.rs:27: use statement is not in alphabetical order
    expected: net::test::{HttpResponse, LoadErrorType}
    found: net::resource_thread::{AuthCacheEntry, CancellationListener}

@KiChjang KiChjang added the S-fails-tidy `./mach test-tidy` reported errors. label Nov 4, 2016
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 6, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 6, 2016

@bors-servo r=nox

@bors-servo
Copy link
Contributor

📌 Commit 88285b6 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 6, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 88285b6 with merge c62ce53...

bors-servo pushed a commit that referenced this pull request Nov 6, 2016
Auto merge of #14063 - servo:privatize-net, r=nox
c62ce53 
Privatize most of the net crate.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14063)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit 88285b6 into master Nov 6, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 6, 2016
@Ms2ger Ms2ger mentioned this pull request Nov 7, 2016
Closed
31 tasks
@Ms2ger Ms2ger deleted the privatize-net branch November 10, 2016 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-fails-tidy `./mach test-tidy` reported errors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ms2ger @highfive @nox @bors-servo @KiChjang @Manishearth