Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a few minimal debugging docs. #14187

Merged
merged 3 commits into from Nov 13, 2016
Merged

Add a few minimal debugging docs. #14187

merged 3 commits into from Nov 13, 2016

Conversation

emilio
Copy link
Member

@emilio emilio commented Nov 12, 2016 •
edited by larsbergstrom

r? @jdm (or anyone else)

This change is Reviewable

@emilio
layout: Only specify parking_lot's nightly feature in layout_thread.
5746a94 
This makes necessary only one line change to remove it if needed.
@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive
Copy link

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 12, 2016
jdm
jdm requested changes Nov 13, 2016
View reviewed changes
Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement over the status quo of no docs :)

docs/debugging.md
## Debugging SpiderMonkey.

You can build Servo with a debug version of SpiderMonkey passing the
`--debug-mozjs` flag to `mach`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./mach build

docs/debugging.md
`--debug-mozjs` flag to `mach`.

Note that this sometimes can cause problems when an existing build exists, so
you might have to delete the `mozjs` build directory, or running `./mach clean`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

or run `./mach clean` before performing the first `--debug-mozjs` build.

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 13, 2016
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Nov 13, 2016
@emilio
Copy link
Member Author

emilio commented Nov 13, 2016

Amended, let me know if you think it's good to go :)

@jdm
Copy link
Member

jdm commented Nov 13, 2016

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 6c5cb9c has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 13, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 6c5cb9c with merge bfd4a0e...

bors-servo pushed a commit that referenced this pull request Nov 13, 2016
Auto merge of #14187 - emilio:rr-docs, r=jdm
bfd4a0e 
Add a few minimal debugging docs.

r? @jdm (or anyone else)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14187)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit 6c5cb9c into servo:master Nov 13, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 13, 2016
@bors-servo bors-servo mentioned this pull request Nov 13, 2016
Merged
5 tasks
@emilio emilio deleted the rr-docs branch November 13, 2016 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm requested changes

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emilio @highfive @jdm @bors-servo