Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up JSTraceable and how we use it #14473

Merged
merged 7 commits into from Dec 7, 2016
Merged

Clean up JSTraceable and how we use it #14473

merged 7 commits into from Dec 7, 2016

Conversation

nox
Copy link
Contributor

@nox nox commented Dec 6, 2016 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

highfive commented Dec 6, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/range.rs, components/script/dom/crypto.rs, components/script/dom/window.rs, components/script/devtools.rs, components/script/dom/document.rs, components/script/dom/abstractworkerglobalscope.rs, components/script/dom/cssrulelist.rs, components/script/dom/servoparser/html.rs, components/script/lib.rs, components/script/dom/macros.rs, components/script/dom/bindings/weakref.rs, components/script/docs/JS-Servos-only-GC.md, components/script/dom/htmllinkelement.rs, components/script/dom/bindings/js.rs, components/script/script_runtime.rs, components/script/dom/node.rs, components/script/dom/keyboardevent.rs, components/script/dom/webgltexture.rs, components/script/dom/servoparser/xml.rs, components/script/dom/bindings/trace.rs, components/script/dom/mediaquerylist.rs
  • @fitzgen: components/script/dom/range.rs, components/script/dom/crypto.rs, components/script/dom/window.rs, components/script/devtools.rs, components/script/dom/document.rs, components/script/dom/abstractworkerglobalscope.rs, components/script/dom/cssrulelist.rs, components/script/dom/servoparser/html.rs, components/script/lib.rs, components/script/dom/macros.rs, components/script/dom/bindings/weakref.rs, components/script/docs/JS-Servos-only-GC.md, components/script/dom/htmllinkelement.rs, components/script/dom/bindings/js.rs, components/script/script_runtime.rs, components/script/dom/node.rs, components/script/dom/keyboardevent.rs, components/script/dom/webgltexture.rs, components/script/dom/servoparser/xml.rs, components/script/dom/bindings/trace.rs, components/script/dom/mediaquerylist.rs
  • @emilio: components/script/dom/webgltexture.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 6, 2016
@highfive
Copy link

highfive commented Dec 6, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!

@nox
Copy link
Contributor Author

nox commented Dec 6, 2016

@bors-servo p=2000

Cc @pcwalton @Ms2ger @Manishearth @jdm

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 7, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 5357659 has been approved by Ms2ger

@highfive highfive assigned Ms2ger and unassigned jdm Dec 7, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 7, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 5357659 with merge 6e4faf1...

bors-servo pushed a commit that referenced this pull request Dec 7, 2016
Auto merge of #14473 - nox:raf-safety, r=Ms2ger
6e4faf1 
Clean up JSTraceable and how we use it

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14473)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 7, 2016
@Manishearth
Copy link
Member

Manishearth commented Dec 7, 2016 •
edited

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 5357659 with merge 32c121b...

bors-servo pushed a commit that referenced this pull request Dec 7, 2016
Auto merge of #14473 - nox:raf-safety, r=Ms2ger
32c121b 
Clean up JSTraceable and how we use it

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14473)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 7, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit 5357659 into servo:master Dec 7, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 7, 2016
This was referenced Dec 7, 2016
Merged
Closed
Closed
Closed
@nox nox deleted the raf-safety branch December 7, 2016 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nox @highfive @Ms2ger @bors-servo @Manishearth @jdm