Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylo bindings update #14492

Merged
merged 6 commits into from
Dec 8, 2016
Merged

stylo bindings update #14492

merged 6 commits into from
Dec 8, 2016

Conversation

heycam
Copy link
Contributor

@heycam heycam commented Dec 8, 2016 •
edited by larsbergstrom
Loading

For the latest m-c stylo sync, on top of #14472.

r? @emilio

This change is Reviewable

@highfive
Copy link

highfive commented Dec 8, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/structs_debug.rs, components/style/binding_tools/regen.py, components/style/gecko_bindings/structs_release.rs
  • @emilio: components/style/gecko_bindings/structs_debug.rs, components/style/binding_tools/regen.py, components/style/gecko_bindings/structs_release.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 8, 2016
@highfive
Copy link

highfive commented Dec 8, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

emilio
emilio approved these changes Dec 8, 2016
View reviewed changes
components/style/binding_tools/regen.py
@@ -106,6 +106,7 @@
"AnonymousContent",
"AudioContext",
"CapturingContentInfo",
"ConsumeStyleBehavior",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be noops, right? They're in the mozilla namespace above. Anyway, happy to clean it up afterwards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason without adding these namespace-less names here, the types didn't get output.

emilio
emilio reviewed Dec 8, 2016
View reviewed changes
components/style/gecko_bindings/structs_debug.rs
extern "C" {
#[link_name = "_ZN7mozilla20ThreadSafeAutoRefCnt12isThreadSafeE"]
pub static ThreadSafeAutoRefCnt_isThreadSafe: bool;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're definitely using clang 3.8, but if you're not building with --features llvm_stable, so I expect stuff to break, like this, and potentially the JSWhyMagic thing.

I'm actually surprised it works so decently to be fair, but that's good :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using --features llvm_stable. Does it make sense to make regen.sh require to a newer clang?

@emilio
Copy link
Member

emilio commented Dec 8, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 3d881f3 has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 8, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 3d881f3 with merge c9370e0...

bors-servo pushed a commit that referenced this pull request Dec 8, 2016
Auto merge of #14492 - heycam:bindings-update-9, r=emilio
c9370e0 
stylo bindings update

<!-- Please describe your changes on the following line: -->

For the latest m-c stylo sync, on top of #14472.

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14492)
<!-- Reviewable:end -->
@emilio emilio mentioned this pull request Dec 8, 2016
Closed
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit 3d881f3 into servo:master Dec 8, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 8, 2016
@emilio
Copy link
Member

emilio commented Dec 8, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heycam @highfive @emilio @bors-servo