codegen: generate stable names for tests functions. #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This is an improvement on the current situation, but I think the numbers will still often change depending on what types we (Gecko) happen to use in templates across the codebase. It would be nice if we could generate names based on the class name and its template arguments, though that might be a bit tricky. r=me on this, though. |
|
Yeah, that has its own sets of dangers/trickiness, in the sense that it's pretty hard to avoid conflicts (plus it's more inefficient). I see what you mean though. This is an improvement over the current situation I think. @bors-servo r=heycam |
|
📌 Commit dd80c27 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 8, 2016
codegen: generate stable names for tests functions. r? @heycam
|
☀️ Test successful - status-travis |
emilio
added a commit
to emilio/servo
that referenced
this pull request
Dec 8, 2016
heycam
pushed a commit
to heycam/servo
that referenced
this pull request
Dec 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @heycam