Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WR (first phase of z-buffer optimizations / improvements). #14818

Merged
merged 2 commits into from Jan 10, 2017
Merged

Update WR (first phase of z-buffer optimizations / improvements). #14818

merged 2 commits into from Jan 10, 2017

Conversation

glennw
Copy link
Member

@glennw glennw commented Jan 1, 2017 •
edited by larsbergstrom

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 1, 2017
@glennw
Copy link
Member Author

glennw commented Jan 1, 2017

r? @pcwalton

@highfive highfive assigned pcwalton and unassigned SimonSapin Jan 1, 2017
@glennw
Copy link
Member Author

glennw commented Jan 1, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 2caa428 with merge 5091397...

bors-servo pushed a commit that referenced this pull request Jan 1, 2017
Auto merge of #14818 - glennw:zb, r=<try>
5091397 
Update WR (first phase of z-buffer optimizations / improvements).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14818)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jan 2, 2017
@glennw
Copy link
Member Author

glennw commented Jan 2, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Trying commit 2caa428 with merge 6808335...

bors-servo pushed a commit that referenced this pull request Jan 2, 2017
Auto merge of #14818 - glennw:zb, r=<try>
6808335 
Update WR (first phase of z-buffer optimizations / improvements).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14818)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jan 2, 2017
@glennw
Copy link
Member Author

glennw commented Jan 2, 2017

@bors-servo retry

  • Infra? (python OSErr exception)

@bors-servo
Copy link
Contributor

⌛ Trying commit 2caa428 with merge c24ce14...

bors-servo pushed a commit that referenced this pull request Jan 2, 2017
Auto merge of #14818 - glennw:zb, r=<try>
c24ce14 
Update WR (first phase of z-buffer optimizations / improvements).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14818)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jan 2, 2017
@glennw
Copy link
Member Author

glennw commented Jan 2, 2017

Any suggestions on what may be causing http://build.servo.org/builders/mac-rel-wpt1/builds/1659/steps/test__1/logs/stdio ?

@jdm
Copy link
Member

jdm commented Jan 2, 2017

Previously seen in #13400, but I don't believe we've ever figured anything out about it.

@glennw
Copy link
Member Author

glennw commented Jan 2, 2017

@bors-servo retry

  • 13400

@bors-servo
Copy link
Contributor

⌛ Trying commit 2caa428 with merge 17063aa...

bors-servo pushed a commit that referenced this pull request Jan 2, 2017
Auto merge of #14818 - glennw:zb, r=<try>
17063aa 
Update WR (first phase of z-buffer optimizations / improvements).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14818)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

@glennw
Copy link
Member Author

glennw commented Jan 2, 2017

@pcwalton OK, this has passed try now, so is ready for review.

@pcwalton
Copy link
Contributor

pcwalton commented Jan 3, 2017

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 2caa428 has been approved by pcwalton

@highfive highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 3, 2017
@jdm
Copy link
Member

jdm commented Jan 9, 2017

I'm ok with disabling the test given that investigation. Thanks!

@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Jan 9, 2017
@glennw
Copy link
Member Author

glennw commented Jan 9, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 3987f62 with merge cc9bc9c...

bors-servo pushed a commit that referenced this pull request Jan 9, 2017
Auto merge of #14818 - glennw:zb, r=<try>
cc9bc9c 
Update WR (first phase of z-buffer optimizations / improvements).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14818)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - windows-msvc-dev

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jan 9, 2017
@glennw
Copy link
Member Author

glennw commented Jan 9, 2017

error: failed to write compressed bytecode: There is not enough space on the disk. (os error 112)

@glennw
Copy link
Member Author

glennw commented Jan 9, 2017

@larsbergstrom Ideas about the above MSVC failure?

@glennw
Copy link
Member Author

glennw commented Jan 9, 2017

@bors-servo retry

  • infra - just in case it magically fixed itself.

@bors-servo
Copy link
Contributor

⌛ Trying commit 3987f62 with merge e83fc0e...

bors-servo pushed a commit that referenced this pull request Jan 9, 2017
Auto merge of #14818 - glennw:zb, r=<try>
e83fc0e 
Update WR (first phase of z-buffer optimizations / improvements).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14818)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

@glennw
Copy link
Member Author

glennw commented Jan 9, 2017

r? @pcwalton or @jdm or anyone?

@jdm
Copy link
Member

jdm commented Jan 9, 2017

@bors-servo: r=pcwalton

@bors-servo
Copy link
Contributor

📌 Commit 3987f62 has been approved by pcwalton

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. S-tests-failed The changes caused existing tests to fail. labels Jan 9, 2017
@glennw
Copy link
Member Author

glennw commented Jan 9, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 3987f62 with merge 851d623...

bors-servo pushed a commit that referenced this pull request Jan 9, 2017
Auto merge of #14818 - glennw:zb, r=pcwalton
851d623 
Update WR (first phase of z-buffer optimizations / improvements).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14818)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

@bors-servo bors-servo merged commit 3987f62 into servo:master Jan 10, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 10, 2017
@bors-servo bors-servo mentioned this pull request Jan 10, 2017
Merged
@glennw glennw deleted the zb branch January 10, 2017 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@glennw @bors-servo @jdm @pcwalton @jgraham @SimonSapin @highfive @gw3583