Add config to do desktop notifications by running an abitrary command. #15013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def notify_with_command(command): | ||
| def notify(title, text): | ||
| import subprocess | ||
| subprocess.check_call([command, title, text]) |
There was a problem hiding this comment.
This should be replaced with the call wrapper imported from command_base
cbrewster
added
the
S-awaiting-review
|
|
||
|
|
||
| def notify(title, text): | ||
| def notify(config, title, text): | ||
| """Generate a desktop notification using appropriate means on | ||
| supported platforms Linux, Windows, and Mac OS. On unsupported | ||
| platforms, this function acts as a no-op.""" |
There was a problem hiding this comment.
Please update this to say that we can also add a custom command to the config for generating a notification.
SimonSapin
force-pushed
the
notify-command
branch
from
6960a2d
to
5168a69
Compare
|
@bors-servo r+ |
|
📌 Commit 5168a69 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jan 13, 2017
Add config to do desktop notifications by running an abitrary command. <!-- Please describe your changes on the following line: --> I now have an usual setup where I use a (fast) remote machine for building, and I’m adding a hack to forward end-of-build notifications back to my laptop. This is the motivation for this change, but I kept it general enough that it could be used in other situations. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15013) <!-- Reviewable:end -->
Please address it if you don't mind. If you feel there's a good reason to not do that change, feel free to r=me after commenting on why. @bors-servo r- |
SimonSapin
force-pushed
the
notify-command
branch
from
5168a69
to
59ee5df
Compare
highfive
added
S-awaiting-review
SimonSapin
force-pushed
the
notify-command
branch
from
59ee5df
to
16d8c35
Compare
|
@bors-servo r=emilio |
|
📌 Commit 16d8c35 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jan 13, 2017
Add config to do desktop notifications by running an abitrary command. <!-- Please describe your changes on the following line: --> I now have an usual setup where I use a (fast) remote machine for building, and I’m adding a hack to forward end-of-build notifications back to my laptop. This is the motivation for this change, but I kept it general enough that it could be used in other situations. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15013) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I now have an usual setup where I use a (fast) remote machine for building, and I’m adding a hack to forward end-of-build notifications back to my laptop. This is the motivation for this change, but I kept it general enough that it could be used in other situations.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is