script: Avoid an allocation when getting attribute data. #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15% improvement in selector matching performance on the rainbow page.
|
Critic review: https://critic.hoppipolla.co.uk/r/636 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
bors-servo
pushed a commit
that referenced
this pull request
Jan 25, 2014
…imonSapin 15% improvement in selector matching performance on the rainbow page. r? @SimonSapin
Ms2ger
added a commit
to Ms2ger/servo
that referenced
this pull request
Jan 25, 2014
SimonSapin
added a commit
to SimonSapin/servo
that referenced
this pull request
Jan 25, 2014
Lower-case attribute names when parsing selectors rather than when matching. This avoid one allocation in matching code.
therealglazou
pushed a commit
to therealglazou/servo
that referenced
this pull request
Feb 20, 2014
therealglazou
pushed a commit
to therealglazou/servo
that referenced
this pull request
Feb 20, 2014
Lower-case attribute names when parsing selectors rather than when matching. This avoid one allocation in matching code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
15% improvement in selector matching performance on the rainbow page.
r? @SimonSapin