Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aho-corasick, backtrace-sys, image, parking_lot, pdqsort, syn, & others #15549

Merged
merged 3 commits into from Feb 14, 2017
Merged

Update aho-corasick, backtrace-sys, image, parking_lot, pdqsort, syn, & others #15549

merged 3 commits into from Feb 14, 2017

Conversation

mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Feb 14, 2017 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml
  • @emilio: components/style/Cargo.toml, components/layout/Cargo.toml

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 14, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify style, layout, and gfx code, but no tests are modified. Please consider adding a test!

@mbrubeck
Copy link
Contributor Author

Oops, the sig change broke something that I missed locally. Not ready to merge yet.

@mbrubeck
Copy link
Contributor Author

Fixed.

@mbrubeck mbrubeck changed the title Update aho-corasick, backtrace-sys, image, parking_lot, pdqsort, sig, syn Update aho-corasick, backtrace-sys, image, parking_lot, pdqsort, syn, & others Feb 14, 2017
@jdm
Copy link
Member

jdm commented Feb 14, 2017

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit c15de82 has been approved by jdm

@highfive highfive assigned jdm and unassigned cbrewster Feb 14, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 14, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit c15de82 with merge 5a624ff...

bors-servo pushed a commit that referenced this pull request Feb 14, 2017
Auto merge of #15549 - mbrubeck:always-be-updating, r=jdm
5a624ff 
Update aho-corasick, backtrace-sys, image, parking_lot, pdqsort, syn, & others

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15549)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: jdm
Pushing 5a624ff to master...

@bors-servo bors-servo merged commit c15de82 into servo:master Feb 14, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 14, 2017
This was referenced Feb 14, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mbrubeck @highfive @jdm @bors-servo @cbrewster