Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylo: Implement align-items and justify-items #15606

Merged
merged 1 commit into from
Feb 19, 2017
Merged

stylo: Implement align-items and justify-items #15606

merged 1 commit into from
Feb 19, 2017

Conversation

mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Feb 16, 2017 •
edited by larsbergstrom
Loading

Stylo-only patch to match Gecko property support. Part of #15001. r? @Manishearth

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/values/specified/mod.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/position.mako.rs, components/style/values/specified/align.rs
  • @emilio: components/style/properties/gecko.mako.rs, components/style/values/specified/mod.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/position.mako.rs, components/style/values/specified/align.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 16, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@Manishearth
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 0a0dd11 has been approved by Manishearth

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 19, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 0a0dd11 with merge 72b7645...

bors-servo pushed a commit that referenced this pull request Feb 19, 2017
Auto merge of #15606 - mbrubeck:align-items, r=Manishearth
72b7645 
stylo: Implement align-items and justify-items

Stylo-only patch to match Gecko property support. Part of #15001. r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15606)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: Manishearth
Pushing 72b7645 to master...

@bors-servo bors-servo merged commit 0a0dd11 into servo:master Feb 19, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 19, 2017
@mbrubeck mbrubeck deleted the align-items branch May 2, 2017 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbrubeck @highfive @Manishearth @bors-servo