Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylo: Backport rust-nsstring crash fixes to the vendored version. #15809

Merged
merged 1 commit into from
Mar 3, 2017
Merged

stylo: Backport rust-nsstring crash fixes to the vendored version. #15809

merged 1 commit into from
Mar 3, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Mar 3, 2017 •
edited by larsbergstrom
Loading

This change is Reviewable

@highfive
Copy link

highfive commented Mar 3, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/nsstring_vendor/src/lib.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 3, 2017
@highfive
Copy link

highfive commented Mar 3, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member Author

emilio commented Mar 3, 2017

@bors-servo r+ p=1

  • Self-r+'ing for the revendoring part. The fix was reviewed upstream by @mystor.

@bors-servo
Copy link
Contributor

📌 Commit feac01f has been approved by emilio

@highfive highfive assigned emilio and unassigned cbrewster Mar 3, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 3, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit feac01f with merge c32181c...

bors-servo pushed a commit that referenced this pull request Mar 3, 2017
Auto merge of #15809 - emilio:nsstuff, r=emilio
c32181c 
stylo: Backport rust-nsstring crash fixes to the vendored version.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15809)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: emilio
Pushing c32181c to master...

@bors-servo bors-servo merged commit feac01f into servo:master Mar 3, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilio @highfive @bors-servo @cbrewster