-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement parsing and serialization of contain property #15955
Comments
Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the If you intend to work on this issue, then add |
@highfive: assign me |
Hey @hgallagher1993! Thanks for your interest in working on this issue. It's now assigned to you! |
@hgallagher1993 You seem to have already claimed another issue, I'm unassigning this one until you finish the other one. |
@highfive: assign me |
Hey @jryans! Thanks for your interest in working on this issue. It's now assigned to you! |
@KiChjang Ehh. . .can you see what issue? Because the last one (I remember) I was assigned I made the pull request for and the issue was closed |
@hgallagher1993 Huh, sorry. This is really odd, I check my notifications daily and I was very sure that I saw you commenting on another issue, I just can't seem to search for it... |
@hgallagher1993 Did you already make progress on this, or should I continue here? |
@jryans I did absolutely nothing with it, so your pull request is fine to go ahead 😄 |
Parsing / serialization for CSS contain Adds parsing / serialization for CSS contain to the style package. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15955 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15972) <!-- Reviewable:end -->
Parsing / serialization for CSS contain Adds parsing / serialization for CSS contain to the style package. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15955 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15972) <!-- Reviewable:end -->
Parsing / serialization for CSS contain Adds parsing / serialization for CSS contain to the style package. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15955 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15972) <!-- Reviewable:end -->
Syntax: https://developer.mozilla.org/en-US/docs/Web/CSS/contain
This property should be added to https://github.com/servo/servo/blob/master/components/style/properties/longhand/box.mako.rs
Hacking guide for adding property: https://github.com/servo/servo/wiki/Property-hacking-guide
The text was updated successfully, but these errors were encountered: