Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parsing and serialization of contain property #15955

Closed
upsuper opened this issue Mar 15, 2017 · 10 comments · Fixed by #15972
Closed

Implement parsing and serialization of contain property #15955

upsuper opened this issue Mar 15, 2017 · 10 comments · Fixed by #15972
Labels
A-content/css Interacting with CSS from web content (parsing, serializing, introspection) C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.

Comments

@upsuper
Copy link
Contributor

upsuper commented Mar 15, 2017

Syntax: https://developer.mozilla.org/en-US/docs/Web/CSS/contain

This property should be added to https://github.com/servo/servo/blob/master/components/style/properties/longhand/box.mako.rs

Hacking guide for adding property: https://github.com/servo/servo/wiki/Property-hacking-guide

@upsuper upsuper added A-content/css Interacting with CSS from web content (parsing, serializing, introspection) E-less-complex Straightforward. Recommended for a new contributor. labels Mar 15, 2017
@highfive
Copy link

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@hgallagher1993
Copy link
Contributor

@highfive: assign me

@highfive highfive added the C-assigned There is someone working on resolving the issue label Mar 15, 2017
@highfive
Copy link

Hey @hgallagher1993! Thanks for your interest in working on this issue. It's now assigned to you!

@KiChjang
Copy link
Contributor

@hgallagher1993 You seem to have already claimed another issue, I'm unassigning this one until you finish the other one.

@KiChjang KiChjang removed the C-assigned There is someone working on resolving the issue label Mar 15, 2017
@jryans
Copy link
Sponsor Contributor

jryans commented Mar 15, 2017

@highfive: assign me

@highfive
Copy link

Hey @jryans! Thanks for your interest in working on this issue. It's now assigned to you!

@highfive highfive added the C-assigned There is someone working on resolving the issue label Mar 15, 2017
@hgallagher1993
Copy link
Contributor

@KiChjang Ehh. . .can you see what issue? Because the last one (I remember) I was assigned I made the pull request for and the issue was closed

@KiChjang
Copy link
Contributor

@hgallagher1993 Huh, sorry. This is really odd, I check my notifications daily and I was very sure that I saw you commenting on another issue, I just can't seem to search for it...

@jryans
Copy link
Sponsor Contributor

jryans commented Mar 15, 2017

@hgallagher1993 Did you already make progress on this, or should I continue here?

@hgallagher1993
Copy link
Contributor

@jryans I did absolutely nothing with it, so your pull request is fine to go ahead 😄

bors-servo pushed a commit that referenced this issue Mar 23, 2017
Parsing / serialization for CSS contain

Adds parsing / serialization for CSS contain to the style package.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15955
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15972)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Mar 23, 2017
Parsing / serialization for CSS contain

Adds parsing / serialization for CSS contain to the style package.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15955
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15972)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Mar 23, 2017
Parsing / serialization for CSS contain

Adds parsing / serialization for CSS contain to the style package.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15955
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15972)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-content/css Interacting with CSS from web content (parsing, serializing, introspection) C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants