Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other values of pointer-events #16397

Closed
upsuper opened this issue Apr 13, 2017 · 4 comments
Closed

Support other values of pointer-events #16397

upsuper opened this issue Apr 13, 2017 · 4 comments
Assignees
Labels

Comments

@upsuper
Copy link
Contributor

upsuper commented Apr 13, 2017

There are several other values we need to support for pointer-events in stylo, which are: visiblePainted visibleFill visibleStroke visible painted fill stroke.

Simply adding

extra_gecko_values="visiblePainted visibleFill visibleStroke visible painted fill stroke",

seems to hit an assertion

assertion failed: `(left == right)` (left: `"visiblePainted"`, right: `"visiblepainted"`): string patterns must be given in ASCII lowercase

which may need some investigation.

@highfive
Copy link

cc @emilio

@nox
Copy link
Contributor

nox commented Apr 13, 2017

The spec doesn't seem to say whether these values are supposed to be case-sensitive or not.

@nox
Copy link
Contributor

nox commented Apr 13, 2017

If they are not, we can just do:

extra_gecko_values="visiblepainted visiblefill visiblestroke visible painted fill stroke"

@upsuper
Copy link
Contributor Author

upsuper commented Apr 14, 2017

Yeah, we can just do that. Although it would be better if we can serialize those values to the canonical form defined in the spec, but it seems Gecko is already serializing them to lowercase form, so it is probably fine to do this for now.

We may want to fix that eventually, but that's definitely not a priority.

@nox nox self-assigned this Apr 18, 2017
bors-servo pushed a commit that referenced this issue Apr 18, 2017
Add extra pointer-events values for Gecko (fixes #16397)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16514)
<!-- Reviewable:end -->
sadmansk pushed a commit to sadmansk/servo that referenced this issue May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants