Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coalesce duplicate selector flags and improve LRUCache. #16432

Merged
merged 2 commits into from
Apr 13, 2017
Merged

Coalesce duplicate selector flags and improve LRUCache. #16432

merged 2 commits into from
Apr 13, 2017

Conversation

bholley
Copy link
Contributor

@bholley bholley commented Apr 13, 2017 •
edited by larsbergstrom
Loading

@bholley
Optimize LRUCache by using a VecDeque.
a325961 
We also reverse the order, so that we don't need iter.rev().
@bholley
Store slow selector flags in a hashmap.
297dc33 
This reduces the flag setting overhead on a pessimal testcase from over a
second to ~20ms.
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/layout_wrapper.rs
  • @fitzgen: components/script/layout_wrapper.rs
  • @emilio: components/style/dom.rs, components/style/gecko/wrapper.rs, components/style/cache.rs, components/style/context.rs, components/style/matching.rs

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style and script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 13, 2017
@bholley
Copy link
Contributor Author

bholley commented Apr 13, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 297dc33 has been approved by bholley

@highfive highfive assigned bholley and unassigned jdm Apr 13, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 13, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 297dc33 with merge ea20bd6...

bors-servo pushed a commit that referenced this pull request Apr 13, 2017
Auto merge of #16432 - bholley:faster_selector_flags, r=bholley
ea20bd6 
Coalesce duplicate selector flags and improve LRUCache.

https://bugzilla.mozilla.org/show_bug.cgi?id=1356148
@bholley
Copy link
Contributor Author

bholley commented Apr 13, 2017

Whoops, I meant r=emilio. Oh well, probably better to not interrupt homu.

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: bholley
Pushing ea20bd6 to master...

@bors-servo bors-servo merged commit 297dc33 into servo:master Apr 13, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholley bholley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bholley @highfive @bors-servo @jdm