Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically clean old nightlies #16487

Merged
merged 2 commits into from
Apr 18, 2017
Merged

Automatically clean old nightlies #16487

merged 2 commits into from
Apr 18, 2017

Conversation

aneeshusa
Copy link
Contributor

@aneeshusa aneeshusa commented Apr 16, 2017 •
edited

Automatically clean old rustc and cargo nightlies on our builders up to preserve disk space.

  • There are tests for these changes OR
  • These changes do not require tests because tested manually

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/util.py, python/servo/bootstrap_commands.py, python/servo/package_commands.py

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 16, 2017
@aneeshusa
Copy link
Contributor Author

r? @larsbergstrom

@aneeshusa aneeshusa mentioned this pull request Apr 16, 2017
Closed
@aneeshusa aneeshusa force-pushed the automatically-clean-old-nightlies branch from feab3dd to 4ea88d4 Compare April 18, 2017 01:41
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #16505) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Apr 18, 2017
@aneeshusa
Move delete function to util.py
b1824f7 
This makes it easier to reuse in other places.
@aneeshusa
Automatically clean old nightlies
060a813 
Add a new `-keep` flag to `./mach clean-nightlies` to control how many
nightlies to keep, which keeps the n most recent nightlies found in git.

Use this to clean old nightlies at the start of each build,
currently keeping 3 nightlies at a time.
@aneeshusa aneeshusa force-pushed the automatically-clean-old-nightlies branch from 4ea88d4 to 060a813 Compare April 18, 2017 13:30
@larsbergstrom
Copy link
Contributor

I'm not sure that we want to delete all of the nightlies. Firefox has gotten a lot of mileage out of being able to do a "binary bisection" to find when bugs were introduced without having to rebuild the product.

That said, it might only be useful for the tarballs and not for the installers themselves.

Thoughts, @metajack & @jdm?

@aneeshusa
Copy link
Contributor Author

@larsbergstrom Sorry that I wasn't clear, this deletes rustc and cargo nightlies, not Servo nightlies! The old compilers take up quite a bit of space, I think ~20GB on the Windows builders.

@larsbergstrom
Copy link
Contributor

@aneeshusa Whoops! I should have read the change instead of just the PR comment. I've done so now and thanks a ton for this!

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 060a813 has been approved by larsbergstrom

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Apr 18, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 060a813 with merge a754c10...

bors-servo pushed a commit that referenced this pull request Apr 18, 2017
Auto merge of #16487 - aneeshusa:automatically-clean-old-nightlies, r…
a754c10 
…=larsbergstrom

Automatically clean old nightlies

<!-- Please describe your changes on the following line: -->

Automatically clean old rustc and cargo nightlies on our builders up to preserve disk space.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #12103 and help with servo/saltfs#321 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because tested manually

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16487)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: larsbergstrom
Pushing a754c10 to master...

@bors-servo bors-servo merged commit 060a813 into servo:master Apr 18, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 18, 2017
@bors-servo bors-servo mentioned this pull request Apr 18, 2017
Closed
5 tasks
@aneeshusa aneeshusa mentioned this pull request Apr 19, 2017
Closed
@edunham edunham mentioned this pull request Jul 5, 2017
Closed
@tigercosmos tigercosmos mentioned this pull request Jan 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test packaging during normal builds to prevent bustage?
5 participants
@aneeshusa @highfive @bors-servo @larsbergstrom @wafflespeanut