font-variant-caps should accept all-small-caps and all-petite-caps #16821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
highfive
added
the
S-awaiting-review
|
@bors-servo r+ |
|
📌 Commit f80690f has been approved by |
highfive
added
S-awaiting-merge
|
Test expectation update diff --git a/layout/reftests/font-features/reftest.list b/layout/reftests/font-features/reftest.list
index 4c7d478..88bc34c 100644
--- a/layout/reftests/font-features/reftest.list
+++ b/layout/reftests/font-features/reftest.list
@@ -60,7 +60,7 @@ HTTP(..) == annotations.html annotations-ref.html
# test for specific features being on and others off, based on prop values
# (debug problems with font-variant-debug.html which displays all props)
fails-if(stylo) HTTP(..) == font-variant-alternates.html font-variant-alternates-ref.html
-fails-if(stylo) HTTP(..) == font-variant-caps.html font-variant-caps-ref.html
+HTTP(..) == font-variant-caps.html font-variant-caps-ref.html
HTTP(..) == font-variant-east-asian.html font-variant-east-asian-ref.html
HTTP(..) == font-variant-ligatures.html font-variant-ligatures-ref.html
HTTP(..) == font-variant-numeric.html font-variant-numeric-ref.html
@@ -99,14 +99,14 @@ random-if(!winWidget&&!cocoaWidget) fails-if(winWidget||cocoaWidget) HTTP(..) ==
HTTP(..) != caps-fallback-smallcaps1.html caps-fallback-default.html
HTTP(..) != caps-fallback-smallcaps2.html caps-fallback-default.html
HTTP(..) != caps-fallback-petitecaps.html caps-fallback-default.html
-fails-if(stylo) HTTP(..) != caps-fallback-allsmallcaps.html caps-fallback-default.html
-fails-if(stylo) HTTP(..) != caps-fallback-allpetitecaps.html caps-fallback-default.html
+HTTP(..) != caps-fallback-allsmallcaps.html caps-fallback-default.html
+HTTP(..) != caps-fallback-allpetitecaps.html caps-fallback-default.html
# -- normal or fallback rendering
HTTP(..) == caps-fallback-smallcaps1.html caps-fallback-smcp.html
HTTP(..) == caps-fallback-smallcaps2.html caps-fallback-smcp.html
HTTP(..) == caps-fallback-petitecaps.html caps-fallback-smcp.html
-fails-if(stylo) HTTP(..) == caps-fallback-allsmallcaps.html caps-fallback-smcpc2sc.html
-fails-if(stylo) HTTP(..) == caps-fallback-allpetitecaps.html caps-fallback-smcpc2sc.html
+HTTP(..) == caps-fallback-allsmallcaps.html caps-fallback-smcpc2sc.html
+HTTP(..) == caps-fallback-allpetitecaps.html caps-fallback-smcpc2sc.html
# font-variant-position fallback
random-if(cocoaWidget||Android) HTTP(..) == subsuper-fallback.html subsuper-fallback-ref.html # bug 1139269
diff --git a/layout/style/test/stylo-failures.md b/layout/style/test/stylo-failures.md
index f7bf802..2126bee 100644
--- a/layout/style/test/stylo-failures.md
+++ b/layout/style/test/stylo-failures.md
@@ -123,7 +123,7 @@ to mochitest command.
* test_align_shorthand_serialization.html [8]
* font-variant-{alternates,east-asian,ligatures,numeric} properties servo/servo#15957
* test_property_syntax_errors.html `font-variant-alternates` [2]
- * test_value_storage.html `font-variant` [176]
+ * test_value_storage.html `font-variant` [167]
* test_specified_value_serialization.html `bug-721136` [1]
* Properties implemented but not in geckolib:
* font-feature-settings property servo/servo#15975 |
bors-servo
pushed a commit
that referenced
this pull request
May 12, 2017
font-variant-caps should accept all-small-caps and all-petite-caps <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16821) <!-- Reviewable:end -->
|
💔 Test failed - mac-dev-unit |
highfive
added
S-tests-failed
bors-servo
pushed a commit
that referenced
this pull request
May 12, 2017
font-variant-caps should accept all-small-caps and all-petite-caps <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16821) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is