Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse -moz-alt-content as a whole content value (fixes #15726) #16947

Merged
merged 1 commit into from
May 22, 2017
Merged

Parse -moz-alt-content as a whole content value (fixes #15726) #16947

merged 1 commit into from
May 22, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented May 19, 2017 •
edited by larsbergstrom
Loading

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/counters.mako.rs, components/style/properties/gecko.mako.rs
  • @emilio: components/style/properties/longhand/counters.mako.rs, components/style/properties/gecko.mako.rs, components/layout/wrapper.rs

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 19, 2017
@nox
Copy link
Contributor Author

nox commented May 19, 2017

https://treeherder.mozilla.org/#/jobs?repo=try&revision=06eff3bfa78e72d64de4470a4edc4cf39c816235

@wafflespeanut
Copy link
Contributor

Nice! @bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit f683561 has been approved by Wafflespeanut

@highfive highfive assigned wafflespeanut and unassigned mbrubeck May 19, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 19, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit f683561 with merge 7e6e4ae...

bors-servo pushed a commit that referenced this pull request May 20, 2017
Auto merge of #16947 - nox:moz-alt-content, r=Wafflespeanut
7e6e4ae 
Parse -moz-alt-content as a whole content value (fixes #15726)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16947)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request May 20, 2017
Merged
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 20, 2017
@wafflespeanut
Copy link
Contributor

Bitrotted by #16967

@wafflespeanut wafflespeanut added S-needs-rebase There are merge conflict errors. and removed S-tests-failed The changes caused existing tests to fail. labels May 21, 2017
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 22, 2017
@nox
Copy link
Contributor Author

nox commented May 22, 2017

@bors-servo r=Wafflespeanut

@bors-servo
Copy link
Contributor

📌 Commit 6bdbced has been approved by Wafflespeanut

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels May 22, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 6bdbced with merge 821359a...

bors-servo pushed a commit that referenced this pull request May 22, 2017
Auto merge of #16947 - nox:moz-alt-content, r=Wafflespeanut
821359a 
Parse -moz-alt-content as a whole content value (fixes #15726)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16947)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 22, 2017
@nox
Copy link
Contributor Author

nox commented May 22, 2017

@bors-servo retry

hdiutil: create failed - error -5341

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, windows-msvc-dev are reusable. Rebuilding only mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2...

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels May 22, 2017
@nox
Copy link
Contributor Author

nox commented May 22, 2017

@bors-servo r=Wafflespeanut

@bors-servo
Copy link
Contributor

📌 Commit 499e814 has been approved by Wafflespeanut

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 22, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 499e814 with merge ba23a3b...

bors-servo pushed a commit that referenced this pull request May 22, 2017
Auto merge of #16947 - nox:moz-alt-content, r=Wafflespeanut
ba23a3b 
Parse -moz-alt-content as a whole content value (fixes #15726)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16947)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt2

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 22, 2017
@nox
Copy link
Contributor Author

nox commented May 22, 2017

@bors-servo retry #16982

@bors-servo
Copy link
Contributor

⌛ Testing commit 499e814 with merge a03d0b8...

bors-servo pushed a commit that referenced this pull request May 22, 2017
Auto merge of #16947 - nox:moz-alt-content, r=Wafflespeanut
a03d0b8 
Parse -moz-alt-content as a whole content value (fixes #15726)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16947)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels May 22, 2017
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: Wafflespeanut
Pushing a03d0b8 to master...

@bors-servo bors-servo merged commit 499e814 into servo:master May 22, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nox @highfive @wafflespeanut @bors-servo @mbrubeck