Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust nightly #17149

Merged
merged 1 commit into from Jun 9, 2017
Merged

Update Rust nightly #17149

merged 1 commit into from Jun 9, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Jun 3, 2017 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

highfive commented Jun 3, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script_plugins/unrooted_must_root.rs
  • @KiChjang: components/script_plugins/unrooted_must_root.rs, components/net/lib.rs, components/net_traits/image/base.rs, components/net_traits/image/base.rs, components/net/image_cache.rs and 2 more

@highfive
Copy link

highfive commented Jun 3, 2017

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 3, 2017
@emilio
Copy link
Member

emilio commented Jun 3, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 9842227 has been approved by emilio

@highfive highfive assigned emilio and unassigned asajeffrey Jun 3, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 3, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 9842227 with merge bf6534e...

bors-servo pushed a commit that referenced this pull request Jun 3, 2017
Auto merge of #17149 - servo:rustup, r=emilio
bf6534e 
Update both Rust versions

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jun 3, 2017
@nox
Copy link
Contributor Author

nox commented Jun 4, 2017

@jdm Does that ring a bell?

@jdm
Copy link
Member

jdm commented Jun 4, 2017

No.

@nox
Copy link
Contributor Author

nox commented Jun 4, 2017

@bors-servo try

@nox
Copy link
Contributor Author

nox commented Jun 4, 2017

@bors-servo r- try

@nox
Copy link
Contributor Author

nox commented Jun 4, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Trying commit 9842227 with merge f6129bf...

bors-servo pushed a commit that referenced this pull request Jun 4, 2017
Auto merge of #17149 - servo:rustup, r=<try>
f6129bf 
Update both Rust versions

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jun 4, 2017
@SimonSapin
Copy link
Member

@bors-servo retry #17166

@bors-servo
Copy link
Contributor

⌛ Trying commit 9842227 with merge 815c47a...

bors-servo pushed a commit that referenced this pull request Jun 5, 2017
Auto merge of #17149 - servo:rustup, r=<try>
815c47a 
Update both Rust versions

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jun 5, 2017
@SimonSapin
Copy link
Member

@bors-servo retry #17166

@bors-servo
Copy link
Contributor

⌛ Trying commit 9842227 with merge cc9c71c...

bors-servo pushed a commit that referenced this pull request Jun 5, 2017
Auto merge of #17149 - servo:rustup, r=<try>
cc9c71c 
Update both Rust versions

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

@Manishearth
Copy link
Member

@bors-servo clean

@Manishearth
Copy link
Member

@bors-servo clean try-

@nox
Copy link
Contributor Author

nox commented Jun 6, 2017

This is ok to land now, right?

@nox
Copy link
Contributor Author

nox commented Jun 7, 2017

@SimonSapin I think you said we shouldn't raise minimum version to 1.17 or something like that?

@SimonSapin
Copy link
Member

Firefox's mach currently checks for 1.15.1+:

http://searchfox.org/mozilla-central/rev/20963d7269b1b14d455f47bc0260d0653015bf84/build/moz.configure/rust.configure#58

This is changed by filing a bug like https://bugzilla.mozilla.org/show_bug.cgi?id=1337153 and CCing @rillian. I don't know if there's a policy for how long we want to support a release before raising the requirement.

@rillian
Copy link
Contributor

rillian commented Jun 7, 2017

Firefox's only policy is that release Firefox be build with stable Rust. Otherwise I've just tried to balance the interests of those wanting new features vs those wanting less churn in their dev environment.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Jun 9, 2017
@nox nox changed the title Update both Rust versions Update Rust nightly Jun 9, 2017
@nox
Copy link
Contributor Author

nox commented Jun 9, 2017

I removed the Rust stable commit given mozilla-central forces us to stay in the past.

@emilio
Copy link
Member

emilio commented Jun 9, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 4c8a0f0 has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 9, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 4c8a0f0 with merge 9656341...

bors-servo pushed a commit that referenced this pull request Jun 9, 2017
Auto merge of #17149 - servo:rustup, r=emilio
9656341 
Update Rust nightly

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 9656341 to master...

@bors-servo bors-servo merged commit 4c8a0f0 into master Jun 9, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 9, 2017
@SimonSapin SimonSapin deleted the rustup branch June 26, 2017 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@nox @highfive @emilio @bors-servo @jdm @SimonSapin @Manishearth @rillian @asajeffrey