Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marginally improve shadows #17494

Merged
merged 2 commits into from
Jun 24, 2017
Merged

Marginally improve shadows #17494

merged 2 commits into from
Jun 24, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Jun 23, 2017 •
edited by larsbergstrom
Loading

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/gecko_bindings/sugar/ns_css_shadow_item.rs, components/style/values/mod.rs, components/style/values/animated/effects.rs, components/style/values/specified/effects.rs and 1 more
  • @emilio: components/style/properties/gecko.mako.rs, components/style/gecko_bindings/sugar/ns_css_shadow_item.rs, components/style/values/mod.rs, components/style/values/animated/effects.rs, components/style/values/specified/effects.rs and 1 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 23, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@nox
Copy link
Contributor Author

nox commented Jun 23, 2017

r? @emilio
@bors-servo try

@highfive highfive assigned emilio and unassigned jdm Jun 23, 2017
@bors-servo
Copy link
Contributor

⌛ Trying commit c9b1232 with merge 4fb53d6...

bors-servo pushed a commit that referenced this pull request Jun 23, 2017
Auto merge of #17494 - servo:derive-all-the-things, r=<try>
4fb53d6 
Marginally improve shadows
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

emilio
emilio approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@emilio
Copy link
Member

emilio commented Jun 23, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit c9b1232 has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 23, 2017
bors-servo pushed a commit that referenced this pull request Jun 24, 2017
Auto merge of #17494 - servo:derive-all-the-things, r=emilio
c586a24 
Marginally improve shadows

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17494)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit c9b1232 with merge c586a24...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing c586a24 to master...

@bors-servo bors-servo merged commit c9b1232 into master Jun 24, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nox @highfive @bors-servo @emilio @jdm