Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Cleanup a bit Stylist and SelectorMap. #18087

Merged
merged 2 commits into from
Aug 16, 2017
Merged

style: Cleanup a bit Stylist and SelectorMap. #18087

merged 2 commits into from
Aug 16, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Aug 15, 2017 •
edited by SimonSapin
Loading

Bug: 1390255
Reviewed-by: heycam

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/data.rs, components/style/stylesheets/origin.rs, components/style/selector_map.rs, components/style/invalidation/element/invalidation_map.rs, components/style/stylesheet_set.rs and 2 more
  • @canaltinova: components/style/gecko/data.rs, components/style/stylesheets/origin.rs, components/style/selector_map.rs, components/style/invalidation/element/invalidation_map.rs, components/style/stylesheet_set.rs and 2 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 15, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member Author

emilio commented Aug 15, 2017

@bors-servo r=heycam p=1

@bors-servo
Copy link
Contributor

📌 Commit bab8e26 has been approved by heycam

@highfive highfive assigned heycam and unassigned jdm Aug 15, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 15, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit bab8e26 with merge a2a0c5f...

bors-servo pushed a commit that referenced this pull request Aug 15, 2017
Auto merge of #18087 - emilio:stylist-clear-cleanup, r=heycam
a2a0c5f 
style: Cleanup a bit Stylist and SelectorMap.

Bug: 1390255
Reviewed-by: heycam

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18087)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 15, 2017
@emilio
Copy link
Member Author

emilio commented Aug 15, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors-servo
Copy link
Contributor

📌 Commit bab8e26 has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 15, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit bab8e26 with merge 4c2f96f139a5a014e058d5be84f649c27a476725...

@emilio
Copy link
Member Author

emilio commented Aug 15, 2017

@bors-servo r-

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 15, 2017
@emilio
Copy link
Member Author

emilio commented Aug 15, 2017

(Forgot to push)

@emilio
Copy link
Member Author

emilio commented Aug 15, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit 10d0dcc has been approved by heycam

@highfive highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Aug 15, 2017
@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Add CompositionEvent bindings #18093

@bors-servo
Copy link
Contributor

📌 Commit dae97bf has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 15, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 16, 2017
@emilio
Copy link
Member Author

emilio commented Aug 16, 2017

@bors-servo r=heycam

  • Bors completely forgot this.

@bors-servo
Copy link
Contributor

📌 Commit 1fd2700 has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 16, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 1fd2700 with merge c1c615bfed51c887003f0d7b8d5df20224b611f9...

@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 16, 2017
@emilio
style: Avoid multiple selector walk-ups during SelectorMap insertion.
b040d79 
MozReview-Commit-ID: 5b2X0GL2753
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@emilio
stylo: Cleanup a bit of the Stylist clear setup.
4c80ccc 
This moves us to clear on rebuild, which allows us to remove yet another place
where we track stylist dirtiness.

Bug: 1390255
Reviewed-by: heycam
MozReview-Commit-ID: nihQbUAbh8
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 16, 2017
@emilio
Copy link
Member Author

emilio commented Aug 16, 2017

@bors-servo r=heycam

  • The rustc update uncovered a warning...

@bors-servo
Copy link
Contributor

📌 Commit 4c80ccc has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 16, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 4c80ccc with merge b300800...

bors-servo pushed a commit that referenced this pull request Aug 16, 2017
Auto merge of #18087 - emilio:stylist-clear-cleanup, r=heycam
b300800 
style: Cleanup a bit Stylist and SelectorMap.

Bug: 1390255
Reviewed-by: heycam

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18087)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing b300800 to master...

@bors-servo bors-servo merged commit 4c80ccc into servo:master Aug 16, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emilio @highfive @bors-servo @jdm @heycam