Move fast checks into earlier Travis task. #18193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
@bors-servo r+ Thanks for coming up with this! |
|
📌 Commit f9dac85 has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo r- I think |
|
On 08/22/2017 08:33 PM, Simon Sapin wrote:
@bors-servo <https://github.com/bors-servo> r-
I think |lockfile_changed.sh| only works after running Cargo.
Oh, indeed, great catch :(.
|
highfive
added
S-awaiting-review
|
The lockfile check has been reverted. |
|
@bors-servo r+ |
|
📌 Commit 39f98a0 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 22, 2017
Move fast checks into earlier Travis task. This allows quicker feedback about whether the manifest needs updating; otherwise it has to wait until all builds and tests are complete. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18193) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows quicker feedback about whether the manifest needs updating; otherwise it has to wait until all builds and tests are complete.
This change is