Add a reusable sheets parameter to Servo_StyleSheet_FromUTF8Bytes. #18207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
|
@bors-servo r=xidorn |
|
@bradwerth: 🔑 Insufficient privileges: Not in reviewers |
|
@bors-servo r=xidorn
|
|
📌 Commit 75a339b has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo delegate+ |
|
✌️ @bradwerth can now approve this pull request |
bors-servo
pushed a commit
that referenced
this pull request
Aug 23, 2017
Add a reusable sheets parameter to Servo_StyleSheet_FromUTF8Bytes. MozReview-Commit-ID: DdMQpUY1WcJ <!-- Please describe your changes on the following line: --> https://bugzilla.mozilla.org/show_bug.cgi?id=1387933 https://reviewboard.mozilla.org/r/171308/ --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18207) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-wpt |
highfive
added
S-tests-failed
|
That's #15227; you can retry. |
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Aug 24, 2017
Add a reusable sheets parameter to Servo_StyleSheet_FromUTF8Bytes. MozReview-Commit-ID: DdMQpUY1WcJ <!-- Please describe your changes on the following line: --> https://bugzilla.mozilla.org/show_bug.cgi?id=1387933 https://reviewboard.mozilla.org/r/171308/ --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18207) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
MozReview-Commit-ID: DdMQpUY1WcJ
bradwerth
force-pushed
the
reuseImports
branch
from
75a339b
to
cdcd7ed
Compare
highfive
added
S-awaiting-review
|
@bors-servo: r=xidorn |
|
📌 Commit cdcd7ed has been approved by |
highfive
removed
the
S-awaiting-review
highfive
added
the
S-awaiting-merge
|
⌛ Testing commit cdcd7ed with merge ab9b154a16a9862b6f03afa1fd90ebf2eb9c47ad... |
|
💔 Test failed - mac-rel-wpt3 |
highfive
added
S-tests-failed
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Aug 24, 2017
Add a reusable sheets parameter to Servo_StyleSheet_FromUTF8Bytes. MozReview-Commit-ID: DdMQpUY1WcJ <!-- Please describe your changes on the following line: --> https://bugzilla.mozilla.org/show_bug.cgi?id=1387933 https://reviewboard.mozilla.org/r/171308/ --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18207) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MozReview-Commit-ID: DdMQpUY1WcJ
https://bugzilla.mozilla.org/show_bug.cgi?id=1387933
https://reviewboard.mozilla.org/r/171308/
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is