Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WR (box shadows, subpixel + alpha text) #18926

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Update WR (box shadows, subpixel + alpha text) #18926

merged 1 commit into from
Oct 19, 2017

Conversation

glennw
Copy link
Member

@glennw glennw commented Oct 17, 2017 •
edited by SimonSapin
Loading

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @emilio: components/layout/webrender_helpers.rs

@glennw
Copy link
Member Author

glennw commented Oct 17, 2017

r? anyone

@highfive
Copy link

warning Warning warning

  • These commits modify gfx and layout code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 17, 2017
@KiChjang
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 9258b06 has been approved by KiChjang

@highfive highfive assigned KiChjang and unassigned mbrubeck Oct 17, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 17, 2017
bors-servo pushed a commit that referenced this pull request Oct 17, 2017
Auto merge of #18926 - glennw:update-wr-bs, r=KiChjang
aa599cd 
Update WR (box shadows, subpixel + alpha text)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18926)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 9258b06 with merge aa599cd...

@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 18, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 18, 2017
@glennw
Copy link
Member Author

glennw commented Oct 18, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 0ab03fc with merge 8bf7fd6...

bors-servo pushed a commit that referenced this pull request Oct 18, 2017
Auto merge of #18926 - glennw:update-wr-bs, r=<try>
8bf7fd6 
Update WR (box shadows, subpixel + alpha text)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18926)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css1

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Oct 18, 2017
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Oct 18, 2017
@glennw
Copy link
Member Author

glennw commented Oct 18, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 4c1c20d with merge c685707...

bors-servo pushed a commit that referenced this pull request Oct 18, 2017
Auto merge of #18926 - glennw:update-wr-bs, r=<try>
c685707 
Update WR (box shadows, subpixel + alpha text)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18926)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

@jdm
Copy link
Member

jdm commented Oct 18, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 4c1c20d has been approved by jdm

@highfive highfive assigned jdm and unassigned KiChjang Oct 18, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 18, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 4c1c20d with merge 59d727b...

bors-servo pushed a commit that referenced this pull request Oct 19, 2017
Auto merge of #18926 - glennw:update-wr-bs, r=jdm
59d727b 
Update WR (box shadows, subpixel + alpha text)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18926)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 59d727b to master...

@bors-servo bors-servo merged commit 4c1c20d into servo:master Oct 19, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@glennw @highfive @KiChjang @bors-servo @jdm @mbrubeck @gw3583