Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backed out changeset dd834d38eaab for Windows debug build bustage #19143

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Backed out changeset dd834d38eaab for Windows debug build bustage #19143

merged 1 commit into from
Nov 8, 2017

Conversation

moz-servo-sync
Copy link
Contributor

@moz-servo-sync moz-servo-sync commented Nov 8, 2017 •
edited by SimonSapin
Loading

Backed out changeset dd834d38eaab for Windows debug build bustage

Backs out #19133

This change is Reviewable

@moz-servo-sync
Copy link
Contributor Author

@bors-servo r+ force p=9001 treeclosed=9000

@bors-servo
Copy link
Contributor

📌 Commit 38b9a54 has been approved by moz-servo-sync

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 8, 2017
@highfive
Copy link

highfive commented Nov 8, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @glennw (or someone else) soon.

@highfive
Copy link

highfive commented Nov 8, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/webidls/TestBinding.webidl, components/script/dom/testbinding.rs, components/script/dom/bindings/codegen/Configuration.py
  • @KiChjang: components/script/dom/webidls/TestBinding.webidl, components/script/dom/testbinding.rs, components/script/dom/bindings/codegen/Configuration.py

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 8, 2017
@KiChjang
Copy link
Contributor

KiChjang commented Nov 8, 2017

@bors-servo treeclosed-

@bors-servo
Copy link
Contributor

⌛ Testing commit 38b9a54 with merge d16902c...

bors-servo pushed a commit that referenced this pull request Nov 8, 2017
Auto merge of #19143 - moz-servo-sync:gecko-backout, r=moz-servo-sync
d16902c 
Backed out changeset dd834d38eaab for Windows debug build bustage

Backed out changeset dd834d38eaab for Windows debug build bustage

Backs out #19133

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19143)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 8, 2017
@upsuper
Copy link
Contributor

upsuper commented Nov 8, 2017

@indygreg It doesn't seem to me this backout is reasonable. Judging from the log, it seems the bustage happened on the original push was just some infra intermittent, and the bustage on your push after that one was some sccache issue. The original push also doesn't touch anything we build in Gecko at all...

@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 8, 2017
@KiChjang
Copy link
Contributor

KiChjang commented Nov 8, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4...

@indygreg
Copy link
Contributor

indygreg commented Nov 8, 2017

It looks like I made a mistake. Sorry for the mix-up.

Please re-land at your earliest convenience,

@jdm
Copy link
Member

jdm commented Nov 8, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt4...

@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Nov 8, 2017
@upsuper
Copy link
Contributor

upsuper commented Nov 8, 2017

@bors-servo treeclosed+

@upsuper
Copy link
Contributor

upsuper commented Nov 8, 2017

@bors-servo r+ force p=9001 treeclosed=9000

@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: style: Get rid of parse_specified. #19139

@bors-servo
Copy link
Contributor

📌 Commit 38b9a54 has been approved by upsuper

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 8, 2017
@upsuper
Copy link
Contributor

upsuper commented Nov 8, 2017

We should not land anything else before backout finishes... which is part of why a servo backout sucks. But making the two repos unsync only makes things suck more.

@upsuper
Copy link
Contributor

upsuper commented Nov 8, 2017

@bors-servo r=moz-servo-sync force p=9001 treeclosed=9000

@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

@bors-servo
Copy link
Contributor

📌 Commit 38b9a54 has been approved by moz-servo-sync

@upsuper
Copy link
Contributor

upsuper commented Nov 8, 2017

@bors-servo retry

@upsuper
Copy link
Contributor

upsuper commented Nov 8, 2017

@bors-servo treeclosed-

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt4...

@upsuper
Copy link
Contributor

upsuper commented Nov 8, 2017

#19145
#19146

These two seem to be the same issue, though, from "Connection reset by peer".

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: moz-servo-sync
Pushing d16902c to master...

@bors-servo bors-servo merged commit 38b9a54 into servo:master Nov 8, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 8, 2017
@KiChjang KiChjang mentioned this pull request Nov 8, 2017
Merged
bors-servo pushed a commit that referenced this pull request Nov 8, 2017
Auto merge of #19148 - KiChjang:import-sequence-inner-types, r=jdm
a1f7337 
Import sequence inner types if it appears in dictionary members

Relands #19133, as it was backed out wrongly in #19143.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19148)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@upsuper upsuper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@moz-servo-sync @bors-servo @highfive @KiChjang @upsuper @indygreg @jdm @glennw