Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove out of date FIXME comments from domimplementation #19724

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Remove out of date FIXME comments from domimplementation #19724

merged 1 commit into from
Jan 9, 2018

Conversation

hindenbug
Copy link
Contributor

@hindenbug hindenbug commented Jan 8, 2018 •
edited
Loading

This removes out of date FIXME comments from domimplementation.rs

  • There are tests for these changes OR
  • These changes do not require tests because this is a comment cleanup

This change is Reviewable

@highfive
Copy link

highfive commented Jan 8, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

@highfive
Copy link

highfive commented Jan 8, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/domimplementation.rs
  • @fitzgen: components/script/dom/domimplementation.rs
  • @KiChjang: components/script/dom/domimplementation.rs

@highfive
Copy link

highfive commented Jan 8, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 8, 2018
@metajack
Copy link
Contributor

metajack commented Jan 9, 2018

@bors-servo r+

Thanks for the contribution!

@bors-servo
Copy link
Contributor

📌 Commit a07ae15 has been approved by metajack

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jan 9, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit a07ae15 with merge aa19930...

bors-servo pushed a commit that referenced this pull request Jan 9, 2018
Auto merge of #19724 - hindenbug:19723-remove-fixme-comments, r=metajack
aa19930 
Remove out of date FIXME comments from domimplementation

<!-- Please describe your changes on the following line: -->
This removes out of date FIXME comments from `domimplementation.rs`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19723

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because this is a comment cleanup

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19724)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jan 9, 2018
@CYBAI
Copy link
Member

CYBAI commented Jan 9, 2018

Failed with #19495

@tigercosmos
Copy link
Contributor

@bors-servo retry

  • gecko-media

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-dev-unit...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: metajack
Pushing aa19930 to master...

@bors-servo bors-servo merged commit a07ae15 into servo:master Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove out-of-date FIXME comments from domimplementation.rs
6 participants
@hindenbug @highfive @metajack @bors-servo @CYBAI @tigercosmos