Merge run.py with run_wpt.py #21201
Labels
A-mach
E-less-complex
Straightforward. Recommended for a new contributor.
I-cleanup
No impact; the issue is one of maintainability or tidiness.
L-python
Python is required
Comments
jdm
added
E-less-complex
|
Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the If you intend to work on this issue, then add |
|
@highfive assign me 🎉 |
bors-servo
pushed a commit
that referenced
this issue
Jul 22, 2018
Merge run_wpt.py into run.py <!-- Please describe your changes on the following line: --> To ensure everything is still works, one can run `./mach test-wpt tests/wpt/mozilla/DOMParser.html` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21201 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21229) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Jul 22, 2018
Merge run_wpt.py into run.py <!-- Please describe your changes on the following line: --> To ensure everything is still works, one can run `./mach test-wpt tests/wpt/mozilla/DOMParser.html` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21201 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21229) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Back when we had two different testsuites that could be invoked in very similar ways, having separate python files in tests/wpt/ made sense. Now that there is only a single one, we should merge the two files so it's less confusing when reading the implementation of test-wpt in
python/servo/testing_commands.py. To ensure everything still works, run./mach test-wpt tests/wpt/mozilla/DOMParser.html.The text was updated successfully, but these errors were encountered: