Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ConstantSourceNode audio node type #21803

Closed
jdm opened this issue Sep 24, 2018 · 11 comments · Fixed by #23919
Closed

Implement ConstantSourceNode audio node type #21803

jdm opened this issue Sep 24, 2018 · 11 comments · Fixed by #23919
Labels
A-content/dom Interacting with the DOM from web content A-content/webaudio C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.
Projects
WebAudio

Comments

@jdm
Copy link
Member

jdm commented Sep 24, 2018 •
edited

Spec: https://webaudio.github.io/web-audio-api/#ConstantSourceNode
Doc: https://developer.mozilla.org/en-US/docs/Web/API/ConstantSourceNode
@jdm jdm added the A-content/dom Interacting with the DOM from web content label Sep 24, 2018
@ferjm ferjm added this to In progress in WebAudio Nov 29, 2018
@ferjm
Copy link
Contributor

ferjm commented Nov 29, 2018 •
edited by jdm

Part of this work happened at servo/media#164

@ferjm ferjm added A-content/webaudio C-assigned There is someone working on resolving the issue labels Nov 29, 2018
@ferjm ferjm removed the C-assigned There is someone working on resolving the issue label Jan 9, 2019
@ferjm ferjm moved this from In progress to To do in WebAudio Jan 9, 2019
@jdm
Copy link
Member Author

jdm commented Jul 4, 2019

#23152 was an attempt to fix this that ran into some compile errors, and then the submitter disappeared.

@jdm jdm added the E-less-complex Straightforward. Recommended for a new contributor. label Jul 4, 2019
@highfive
Copy link

highfive commented Jul 4, 2019

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@jdm jdm changed the title Implement ConstantSourceNode Implement ConstantSourceNode audio node type Jul 4, 2019
@holmes2
Copy link

holmes2 commented Jul 5, 2019

@highfive: assign me

@highfive
Copy link

highfive commented Jul 5, 2019

Hey @holmes2! Thanks for your interest in working on this issue. It's now assigned to you!

@highfive highfive added the C-assigned There is someone working on resolving the issue label Jul 5, 2019
@jdm
Copy link
Member Author

jdm commented Jul 5, 2019

Please ask questions if any part of this task is unclear :)

@jdm
Copy link
Member Author

jdm commented Jul 23, 2019

@KritR If you want to work on this issue, you could.

@KritR
Copy link

KritR commented Jul 23, 2019

Thanks for the issue @jdm. I'll be a little bit occupied until this weekend, and if it's still open then I'll pick it up.

@jdm jdm removed the C-assigned There is someone working on resolving the issue label Jul 23, 2019
@jdm
Copy link
Member Author

jdm commented Jul 23, 2019

Unassigning due to lack of activity.

@tdelacour
Copy link

@highfive assign me

@highfive highfive added the C-assigned There is someone working on resolving the issue label Jul 27, 2019
@highfive
Copy link

Hey @tdelacour! Thanks for your interest in working on this issue. It's now assigned to you!

@tdelacour tdelacour mentioned this issue Aug 6, 2019
Merged
5 tasks
bors-servo pushed a commit that referenced this issue Aug 10, 2019
Auto merge of #23919 - tdelacour:ISSUE-21803, r=jdm
1fd8015 
ISSUE-21803: Implement ConstantSourceNode audionode

<!-- Please describe your changes on the following line: -->
More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21803 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Aug 12, 2019
Auto merge of #23919 - tdelacour:ISSUE-21803, r=<try>
7120e3c 
ISSUE-21803: Implement ConstantSourceNode audionode

<!-- Please describe your changes on the following line: -->
More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21803 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Aug 15, 2019
Auto merge of #23919 - tdelacour:ISSUE-21803, r=jdm
36e6896 
ISSUE-21803: Implement ConstantSourceNode audionode

<!-- Please describe your changes on the following line: -->
More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21803 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Aug 15, 2019
Auto merge of #23919 - tdelacour:ISSUE-21803, r=jdm
60c1908 
ISSUE-21803: Implement ConstantSourceNode audionode

<!-- Please describe your changes on the following line: -->
More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21803 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919)
<!-- Reviewable:end -->
@atouchet atouchet moved this from To do to Done in WebAudio Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content A-content/webaudio C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.
Projects
WebAudio
Status: Done
WebAudio
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUE-21803: Implement ConstantSourceNode audionode tdelacour/servo
6 participants
@jdm @ferjm @tdelacour @highfive @KritR @holmes2