Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TexSubImage2D obtains the full image pixels then uses a subset #21996

Open
Tracked by #22309
jdm opened this issue Oct 22, 2018 · 1 comment
Open
Tracked by #22309

TexSubImage2D obtains the full image pixels then uses a subset #21996

jdm opened this issue Oct 22, 2018 · 1 comment
Labels
A-content/webgl 3d canvas API I-perf-slow Unnecessary performance degredation.

Comments

@jdm
Copy link
Member

jdm commented Oct 22, 2018

The get_image_pixels helper obtains the entire image pixels. I could imagine this being particularly wasteful when we fix #21995, where the video frames are significantly larger that the content that is displayed at any given moment. It would be wise to support obtaining only the necessary pixels for a given rectangle instead.

@jdm jdm added I-perf-slow Unnecessary performance degredation. A-content/webgl 3d canvas API labels Oct 22, 2018
@nox
Copy link
Contributor

nox commented Nov 20, 2018

#22225 makes that code use a IpcSharedMemory, which means that for things such as HTMLImageElement we don't need to copy any pixel at all in this method. The same should be done for HTMLVideoElement.

I'm not sure what you mean that video frames are larger than the content they are displayed in.

@ferjm ferjm mentioned this issue Nov 29, 2018
4 tasks
@ferjm ferjm added this to To do in Media playback Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-content/webgl 3d canvas API I-perf-slow Unnecessary performance degredation.
Projects
Media playback
  
To do
Development

No branches or pull requests

2 participants