Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly test range requests to file urls #22269

Open
ferjm opened this issue Nov 26, 2018 · 1 comment
Open

Properly test range requests to file urls #22269

ferjm opened this issue Nov 26, 2018 · 1 comment

Comments

@ferjm
Copy link
Contributor

ferjm commented Nov 26, 2018

#22024 introduced a test to check the implementation of range requests to file urls. However, the test is not really testing that as it is naively using http urls instead :\ .

I tried changing this in #22134 with this patch. But, I couldn't figure out an easy way to make the update manifest tool ignore the generated resources.js file. So I am filing this issue to track the remaining work.

@jdm
Copy link
Member

jdm commented Nov 26, 2018

@jgraham what's the next step to investigate if adding a top-level .gitignore entry did not make a difference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants