Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent failure in /fetch/content-type/response.window.html #22304

Closed
jdm opened this issue Nov 28, 2018 · 0 comments · Fixed by #29640
Closed

Intermittent failure in /fetch/content-type/response.window.html #22304

jdm opened this issue Nov 28, 2018 · 0 comments · Fixed by #29640
Labels
I-intermittent Problem reproduces intermittently.

Comments

@jdm
Copy link
Member

jdm commented Nov 28, 2018 


  ▶ Unexpected subtest result in /fetch/content-type/response.window.html:
  │ FAIL [expected NOTRUN] Request: combined response Content-Type: text/plain 
  └   → promise_test: Unhandled rejection with value: object "TypeError: Value is not valid"

  ▶ Unexpected subtest result in /fetch/content-type/response.window.html:
  │ FAIL [expected NOTRUN] Response: combined response Content-Type: text/plain 
  └   → promise_test: Unhandled rejection with value: object "TypeError: Value is not valid"

  ▶ Unexpected subtest result in /fetch/content-type/response.window.html:
  │ TIMEOUT [expected NOTRUN] Response: combined response Content-Type: text/html text/plain
  └   → Test timed out

  ▶ Unexpected subtest result in /fetch/content-type/response.window.html:
  │ FAIL [expected NOTRUN] Request: combined response Content-Type: text/html text/plain
  │   → assert_equals: expected "text/plain" but got ""
  │ 
  │ runRequestResponseTest/<@http://web-platform.test:8000/fetch/content-type/response.window.js:70:5
  │ async*Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1568:20
  │ promise_test/tests.promise_tests</<@http://web-platform.test:8000/resources/testharness.js:591:31
  └ promise_test/tests.promise_tests<@http://web-platform.test:8000/resources/testharness.js:590:20

  ▶ Unexpected subtest result in /fetch/content-type/response.window.html:
  │ FAIL [expected TIMEOUT] fetch(): combined response Content-Type: text/plain 
  │   → assert_equals: expected "text/plain" but got ""
  │ FAIL [expected NOTRUN] fetch(): separate response Content-Type: text/html text/plain
  │   → assert_equals: expected "text/plain" but got ""
  │ FAIL [expected NOTRUN] fetch(): combined response Content-Type: text/html text/plain
  │   → assert_equals: expected "text/plain" but got ""
  │ 
  │ runFetchTest/<@http://web-platform.test:8000/fetch/content-type/response.window.js:57:5
  │ async*Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1568:20
  │ promise_test/tests.promise_tests</<@http://web-platform.test:8000/resources/testharness.js:591:31
  └ promise_test/tests.promise_tests<@http://web-platform.test:8000/resources/testharness.js:590:20
@jdm jdm added the I-intermittent Problem reproduces intermittently. label Nov 28, 2018
This was referenced Apr 13, 2023
Merged
Merged
Merged
@CYBAI CYBAI mentioned this issue Apr 17, 2023
Merged
4 tasks
bors-servo added a commit that referenced this issue Apr 17, 2023
@bors-servo
Auto merge of #29640 - CYBAI:fix-response-empty-init, r=<try>
60c3207 
Reset to in-memory stream with empty byte sequence for None init body

Because the response body stream is initialized with FetchResponse, it cannot be processed with in-memory empty sequence. Thus, instead of using the FetchResponse stream, we'll reset it to Memory body stream with empty byte sequence if there's no init body.

With this PR, we can fix the TIMEOUT in `/fetch/content-type/response.window.html` so I think it should fix #22304.

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22304
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Apr 17, 2023
@bors-servo
Auto merge of #29640 - CYBAI:fix-response-empty-init, r=<try>
8178702 
Reset to in-memory stream with empty byte sequence for None init body

Because the response body stream is initialized with FetchResponse, it cannot be processed with in-memory empty sequence. Thus, instead of using the FetchResponse stream, we'll reset it to Memory body stream with empty byte sequence if there's no init body.

With this PR, we can fix the TIMEOUT in `/fetch/content-type/response.window.html` so I think it should fix #22304.

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22304
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Apr 18, 2023
@bors-servo
Auto merge of #29640 - CYBAI:fix-response-empty-init, r=<try>
708ba3e 
Reset to in-memory stream with empty byte sequence for None init body

Because the response body stream is initialized with FetchResponse, it cannot be processed with in-memory empty sequence. Thus, instead of using the FetchResponse stream, we'll reset it to Memory body stream with empty byte sequence if there's no init body.

With this PR, we can fix the TIMEOUT in `/fetch/content-type/response.window.html` so I think it should fix #22304.

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22304
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Apr 19, 2023
@bors-servo
Auto merge of #29640 - CYBAI:fix-response-empty-init, r=<try>
1e6396a 
Reset to in-memory stream with empty byte sequence for None init body

Because the response body stream is initialized with FetchResponse, it cannot be processed with in-memory empty sequence. Thus, instead of using the FetchResponse stream, we'll reset it to Memory body stream with empty byte sequence if there's no init body.

With this PR, we can fix the TIMEOUT in `/fetch/content-type/response.window.html` so I think it should fix #22304.

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22304
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Apr 27, 2023
@bors-servo
Auto merge of #29640 - CYBAI:fix-response-empty-init, r=<try>
4c12873 
Reset to in-memory stream with empty byte sequence for None init body

Because the response body stream is initialized with FetchResponse, it cannot be processed with in-memory empty sequence. Thus, instead of using the FetchResponse stream, we'll reset it to Memory body stream with empty byte sequence if there's no init body.

With this PR, we can fix the TIMEOUT in `/fetch/content-type/response.window.html` so I think it should fix #22304.

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22304
- [x] There are tests for these changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-intermittent Problem reproduces intermittently.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reset to in-memory stream with empty byte sequence for None init body CYBAI/servo
1 participant
@jdm