Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation without GStreamer #23050

Closed
chazanov opened this issue Mar 16, 2019 · 4 comments · Fixed by #24668
Closed

Compilation without GStreamer #23050

chazanov opened this issue Mar 16, 2019 · 4 comments · Fixed by #24668
Labels
A-build Related to or part of the build process

Comments

@chazanov
Copy link

As GStreamer is a real hassle I would like to ask for the compilation option to compile without it.

@jdm jdm added the A-build Related to or part of the build process label Mar 18, 2019
@jdm
Copy link
Member

jdm commented Mar 18, 2019

This should be easy to accomplish in a few steps:

@chazanov
Copy link
Author

chazanov commented Apr 3, 2019

@jdm Hi Josh, what's the current status? Have you implemented this?

@paulrouget
Copy link
Contributor

This should be easy to accomplish in a few steps

I gave it a try. I'm not sure it's easy, we can't have a feature that "disable" something in Cargo.toml. The rustc feature will work, but something like this in Cargo.toml won't:

[target.'cfg(all(target="android", feature="disable-gstreamer"))'.dependencies]

It's a known limitation of Cargo (see rust-lang/cargo#5499).

So I think we will need an intermediate crate (relevant irc conversation: https://mozilla.logbot.info/servo/20190514#c16308257).

I'm open to any other ideas.

@ghost
Copy link

ghost commented Nov 21, 2019

Fixed in #24668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Related to or part of the build process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants