Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put back malloc_size_of_derive in our repository #24419

Closed
nox opened this issue Oct 11, 2019 · 2 comments
Closed

Put back malloc_size_of_derive in our repository #24419

nox opened this issue Oct 11, 2019 · 2 comments

Comments

@nox
Copy link
Contributor

nox commented Oct 11, 2019

It makes no sense that we are using a crate from crates.io to derive a trait that is not on crates.io.
@nox
Copy link
Contributor Author

nox commented Oct 11, 2019

Cc @emilio

@nox nox mentioned this issue Oct 11, 2019
Closed
8 tasks
twilco added a commit to twilco/servo that referenced this issue Oct 12, 2019
@twilco
Move malloc_size_of_derive back into the Servo repo
b20d3f8 
The 'MallocSizeOf' trait is not available on crates.io, so the derive shouldn't be either.  Move this derive back into the Servo repository.

See issue servo#24419.
@twilco twilco mentioned this issue Oct 12, 2019
Closed
4 tasks
twilco added a commit to twilco/servo that referenced this issue Oct 12, 2019
@twilco
Move malloc_size_of_derive back into the Servo repo
634e6d2 
The 'MallocSizeOf' trait is not available on crates.io, so the derive shouldn't be either.  Move this derive back into the Servo repository.

See issue servo#24419.
@jdm
Copy link
Member

jdm commented Oct 15, 2019

Since WebRender needs it, this is difficult.

@jdm jdm closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move malloc_size_of_derive back into the Servo repo twilco/servo
2 participants
@jdm @nox