-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use surfman for managing GL surfaces #24482
Conversation
Heads up! This PR modifies the following files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed a lot of webgl_thread.rs but overall this looks like it's in good shape.
@bors-servo try |
🔒 Merge conflict |
@bors-servo try |
Use surfman for managing GL surfaces <!-- Please describe your changes on the following line: --> Replaces texture sharing with surfman surface sharing. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23509 and #24256 - [x] These changes do not require tests because this is backend gfx <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
💔 Test failed - linux-rel-wpt |
Most comments addressed, the outstanding one is about depth/stencil/alpha. |
Build failures are caused by the warnings caused by WebVR not being implemented. |
@bors-servo try |
Use surfman for managing GL surfaces <!-- Please describe your changes on the following line: --> Replaces texture sharing with surfman surface sharing. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23509 and #24256 - [x] These changes do not require tests because this is backend gfx <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
💔 Test failed - linux-rel-css |
The android build is failing because something is causing a |
Also be aware: the WPT tests on linux had a lot of failures: https://build.servo.org/builders/linux-rel-css/builds/13780 |
They're all crashes of:
|
Squashed. @bors-servo r=jdm |
📌 Commit a358bca has been approved by |
Use surfman for managing GL surfaces <!-- Please describe your changes on the following line: --> Replaces texture sharing with surfman surface sharing. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23509 and #24256 - [x] These changes do not require tests because this is backend gfx <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
💔 Test failed - status-taskcluster |
@bors-servo retry force |
💣 Failed to start rebuilding: |
Use surfman for managing GL surfaces <!-- Please describe your changes on the following line: --> Replaces texture sharing with surfman surface sharing. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23509 and #24256 - [x] These changes do not require tests because this is backend gfx <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster |
Replaces texture sharing with surfman surface sharing.
./mach build -d
does not report any errors./mach test-tidy
does not report any errors