Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove webgl resizing code that talks to webrender #24601

Open
jdm opened this issue Oct 31, 2019 · 2 comments
Open

Remove webgl resizing code that talks to webrender #24601

jdm opened this issue Oct 31, 2019 · 2 comments
Labels
A-content/webgl 3d canvas API I-cleanup No impact; the issue is one of maintainability or tidiness.

Comments

@jdm
Copy link
Member

jdm commented Oct 31, 2019

It should no longer be necessary to inform WebRender when a resize occurs, because we send a size along with the image every frame. We should do this cleanup after #24482 is merged.
@jdm jdm added I-cleanup No impact; the issue is one of maintainability or tidiness. A-content/webgl 3d canvas API labels Oct 31, 2019
@asajeffrey
Copy link
Member

Meaning a resize of the canvas / default framebuffer, not a resize of the browser window?

@jdm
Copy link
Member Author

jdm commented Oct 31, 2019

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/webgl 3d canvas API I-cleanup No impact; the issue is one of maintainability or tidiness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @asajeffrey