Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some fmt::show implementations to make debugging layout easier. #2468

Merged
merged 1 commit into from
May 23, 2014
Merged

Add some fmt::show implementations to make debugging layout easier. #2468

merged 1 commit into from
May 23, 2014

Conversation

glennw
Copy link
Member

@glennw glennw commented May 21, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/1602

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
  • @glennw, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!

@glennw
Copy link
Member Author

glennw commented May 21, 2014

r? @metajack

bors-servo pushed a commit that referenced this pull request May 22, 2014
auto merge of #2468 : glennw/servo/show-traits, r=pcwalton
ee0f4d4
@metajack
Copy link
Contributor

Closing temporarily to unstick bors.

@metajack metajack closed this May 22, 2014
@metajack metajack reopened this May 22, 2014
bors-servo pushed a commit that referenced this pull request May 22, 2014
auto merge of #2468 : glennw/servo/show-traits, r=pcwalton
26e84f4
@glennw
Copy link
Member Author

glennw commented May 23, 2014

Does this need to be rebased?

r? @metajack

@glennw
Copy link
Member Author

glennw commented May 23, 2014

Rebased to after rust upgrade, so should be OK to merge.

bors-servo pushed a commit that referenced this pull request May 23, 2014
auto merge of #2468 : glennw/servo/show-traits, r=jdm
45f9372
bors-servo pushed a commit that referenced this pull request May 23, 2014
auto merge of #2468 : glennw/servo/show-traits, r=jdm
1d26e14
bors-servo pushed a commit that referenced this pull request May 23, 2014
auto merge of #2468 : glennw/servo/show-traits, r=jdm
cad6dff
@bors-servo bors-servo merged commit 39ce07d into servo:master May 23, 2014
@glennw glennw deleted the show-traits branch June 26, 2014 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@glennw @hoppipolla-critic-bot @highfive @metajack @jdm @bors-servo @gw3583