Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script indirectly depends on webrender #24686

Open
jdm opened this issue Nov 7, 2019 · 1 comment
Open

script indirectly depends on webrender #24686

jdm opened this issue Nov 7, 2019 · 1 comment
Labels
A-build Related to or part of the build process I-perf-slow Unnecessary performance degredation.

Comments

@jdm
Copy link
Member

jdm commented Nov 7, 2019

Theoretically script only needs to depend on webrender_api, but we have:
script -> media -> webrender_traits -> webrender

It would be great to break this dependency. webrender_traits only uses webrender::ExternalImageHandler and webrender::ExternalImage. It seems like these should be part of the public webrender_api crate instead.
@jdm jdm added I-perf-slow Unnecessary performance degredation. A-build Related to or part of the build process labels Nov 7, 2019
@jdm
Copy link
Member Author

jdm commented Nov 7, 2019

servo/webrender#3796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build Related to or part of the build process I-perf-slow Unnecessary performance degredation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdm