Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow tests in dom/ranges #25673

Open
pshaughn opened this issue Feb 1, 2020 · 1 comment
Open

Slow tests in dom/ranges #25673

pshaughn opened this issue Feb 1, 2020 · 1 comment
Labels
I-perf-slow Unnecessary performance degredation.

Comments

@pshaughn
Copy link
Member

pshaughn commented Feb 1, 2020 •
edited

Running dom/ranges/Range-insertNode.html, Range-surroundContents.html, and Range-surroundContents.html against a debug build on master currently gives my VM harness timeouts, even with a high timeout-multiplier. No individual test case seems responsible.
@pshaughn pshaughn changed the title Slow tests in dom/ranges Slow tests in dom/ranges and selection Feb 1, 2020
@pshaughn pshaughn changed the title Slow tests in dom/ranges and selection Slow tests in dom/ranges Feb 2, 2020
@pshaughn
Copy link
Member Author

pshaughn commented Feb 2, 2020 •
edited

selection/deleteFromDocument.html is also timing out for me (on my #25674 branch) and might or might not be related

@pshaughn pshaughn mentioned this issue Feb 2, 2020
Merged
bors-servo pushed a commit that referenced this issue Feb 2, 2020
Auto merge of #25674 - pshaughn:selection, r=<try>
3daa787 
Selection DOM interface (but not actual UI selections)

This is work towards #7492.

Things that aren't done here:
- The spec doesn't describe what tests/wpt/metadata/selection/script-and-style-elements.html.ini wants, and what it wants seems to require some sort of layout query.
- #25673 means I'm not sure about some tests being OK.
- I haven't checked that the selectionchange event is actually working, and it has no WPT tests other than that the handler exists.
- Actual UI interactions are not present at all; selection.rs has a few TODOs saying methods what I understand the UI should call for what actions, but there are a lot of fine points here that I don't know about.
@jdm jdm added the I-perf-slow Unnecessary performance degredation. label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-perf-slow Unnecessary performance degredation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @pshaughn