Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure UWP app can run #25745

Closed
wants to merge 11 commits into from
Closed

make sure UWP app can run #25745

wants to merge 11 commits into from

Conversation

paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Feb 12, 2020 •
edited

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.

@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 12, 2020
@paulrouget paulrouget changed the title WIP: make sure UWP app can run make sure UWP app can run Feb 13, 2020
@paulrouget
Copy link
Contributor Author

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit 329d693 with merge 5067c9b...

bors-servo pushed a commit that referenced this pull request Feb 13, 2020
Auto merge of #25745 - paulrouget:uwptest, r=<try>
5067c9b 
make sure UWP app can run

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Feb 13, 2020
@paulrouget
Copy link
Contributor Author

Cannot import the key file 'ServoApp_TemporaryKey.pfx'. The key file may be password protected. To correct this, try to import the certificate manually into the current user's personal certificate store.
A certificate with thumbprint 'DC99ACEDA24EBA00BFB07A3986BB6892B0DE278B' that is specified in the project cannot be found in the certificate store. Please specify a valid thumbprint in the project file.> The certificate specified is not valid for signing. For more information about valid certificates, see http://go.microsoft.com/fwlink/?LinkID=241478.

@paulrouget paulrouget closed this Feb 13, 2020
@paulrouget
Copy link
Contributor Author

(closed the wrong issue)

@paulrouget paulrouget reopened this Feb 13, 2020
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Feb 13, 2020
@paulrouget
Copy link
Contributor Author

@bors-servo try=windows

bors-servo pushed a commit that referenced this pull request Feb 13, 2020
Auto merge of #25745 - paulrouget:uwptest, r=<try>
8050dfa 
make sure UWP app can run

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
@bors-servo
Copy link
Contributor

⌛ Trying commit c5f8529 with merge 8050dfa...

@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Feb 13, 2020
@paulrouget
Copy link
Contributor Author

Administrator permissions are needed to use the selected options. Use an administrator command prompt to complete these tasks.

Damn.

@paulrouget
Copy link
Contributor Author

Is it possible to install the certificate into the taskcluster CI?

@paulrouget
Copy link
Contributor Author

From IRC:

@SimonSapin │ We might need to do that when building the VM image                                                                                         By adding something in https://github.com/servo/taskcluster-config/blob/master/config/windows-first-boot.ps1                                      │
and running https://github.com/servo/taskcluster-config#mach-new-ami-creating-a-new-vm-image-for-windows-workers         
this script is a bit fragile and annoying to debug, and requires access to our AWS account. I could do the rebuild if you’d like            │
If you provide a PowerShell script to run as admin

@paulrouget
Copy link
Contributor Author

This has to be useful: https://docs.microsoft.com/en-us/windows/msix/package/packaging-uwp-apps#install-your-app-package-using-an-install-script

@paulrouget
Copy link
Contributor Author

And https://stackoverflow.com/questions/39951545/powershell-install-add-appdevpackage-ps1-package-fail-can-not-find-any-package/42136370#42136370

@paulrouget
Copy link
Contributor Author

And https://docs.microsoft.com/en-us/windows-hardware/drivers/install/installing-test-certificates

@paulrouget paulrouget mentioned this pull request Feb 14, 2020
Closed
4 tasks
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Feb 14, 2020
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Apr 1, 2020
@paulrouget
Copy link
Contributor Author

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit 1742078 with merge 3d406cd...

bors-servo added a commit that referenced this pull request Apr 1, 2020
@bors-servo
Auto merge of #25745 - paulrouget:uwptest, r=<try>
3d406cd 
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 1, 2020
@paulrouget
Copy link
Contributor Author

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit 1fbfa32 with merge c3a58f8...

bors-servo added a commit that referenced this pull request Apr 1, 2020
@bors-servo
Auto merge of #25745 - paulrouget:uwptest, r=<try>
c3a58f8 
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Apr 1, 2020
@paulrouget
Copy link
Contributor Author

@bors-servo try=windows-rdp

@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Apr 6, 2020
@paulrouget
Copy link
Contributor Author

@bors-servo try=windows-rdp

@bors-servo
Copy link
Contributor

⌛ Trying commit 21594a0 with merge 25a6196...

bors-servo added a commit that referenced this pull request Apr 6, 2020
@bors-servo
Auto merge of #25745 - paulrouget:uwptest, r=<try>
25a6196 
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 6, 2020
@paulrouget
Copy link
Contributor Author

paulrouget commented Apr 6, 2020 •
edited

Same machine. Installing the app exactly the same way. 2 different accounts: one created by the task, one created manually replicating the TC user creation script, the user manually created can run the app. The user created by TC cannot.

@paulrouget
Copy link
Contributor Author

paulrouget commented Apr 6, 2020 •
edited

This is how I manually create a user:

net user tmp1 "xxx" /add /expires:never /passwordchg:no /y
wmic useraccount where name='tmp1' set passwordexpires=false
net localgroup "Remote Desktop Users" /add tmp1

This is the script I run:

$(Get-AppxPackage MozillaFoundation.FirefoxReality)| Remove-AppxPackage
$url = "https://community-tc.services.mozilla.com/api/queue/v1/task/a5TVjKpZTk-Df-uZcQFhxw/runs/0/artifacts/public/ServoApp_1.0.0.0_Debug_Test.zip"
Invoke-WebRequest -Uri $url -OutFile tc.zip
Expand-Archive tc.zip
Set-Location -Path tc\servo\
Add-AppxPackage -Path Dependencies\x64\Microsoft.VCLibs.x64.Debug.14.00.appx
Add-AppxPackage -Path ServoApp_1.0.0.0_x64_Debug.msixbundle
$fam = Get-AppxPackage MozillaFoundation.FirefoxReality | select -expandproperty PackageFamilyName
Start-Process shell:AppsFolder\$fam!App

With a task user, the app opens for a second and closes.
With a manually created user, the app stays open.

@paulrouget
Copy link
Contributor Author

Maybe a clue: the user created by the task can't open the Windows menu.

@paulrouget
Copy link
Contributor Author

Filed a taskcluster issue. Hopefully someone with a better understanding of TC & Windows can help: https://bugzilla.mozilla.org/show_bug.cgi?id=1627906

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #26197) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Apr 16, 2020
@jdm jdm closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add UWP smoketest to CI
5 participants
@paulrouget @highfive @bors-servo @jdm @asajeffrey