Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Background-Hang-Monitor opts in multi-process #26088

Closed
gterzian opened this issue Apr 1, 2020 · 3 comments · Fixed by #26106
Closed

Check for Background-Hang-Monitor opts in multi-process #26088

gterzian opened this issue Apr 1, 2020 · 3 comments · Fixed by #26106
Labels
A-constellation Involves the constellation C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.

Comments

@gterzian
Copy link
Member

gterzian commented Apr 1, 2020

In single-process mode, we only start a BHM if the options has been set:

if opts::get().background_hang_monitor {

But we don't perform this check before starting the BHM in multi-process mode:

let background_hang_monitor_register =

I think we should. The same opts is available there as well.

@gterzian gterzian added A-constellation Involves the constellation E-less-complex Straightforward. Recommended for a new contributor. labels Apr 1, 2020
@highfive
Copy link

highfive commented Apr 1, 2020

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@qrasmont
Copy link
Contributor

qrasmont commented Apr 1, 2020

@highfive: assign me
Ok first ever contribution, let's have a go!

@highfive highfive added the C-assigned There is someone working on resolving the issue label Apr 1, 2020
@highfive
Copy link

highfive commented Apr 1, 2020

Hey @qrasmont! Thanks for your interest in working on this issue. It's now assigned to you!

@kunalmohan
Copy link
Contributor

@gterzian Just out of curiosity, what are single-process and multiprocess modes? What does a single process constitute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-constellation Involves the constellation C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants