Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more internal mutability for DOM objects. #2633

Merged
merged 13 commits into from Jun 11, 2014
Merged

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jun 10, 2014

Part of #1854.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/1787

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
  • @Ms2ger, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!

bors-servo pushed a commit that referenced this pull request Jun 10, 2014
@jdm
Copy link
Member

jdm commented Jun 10, 2014

13:51:41     INFO -  task 'ScriptTask' failed at 'RefCell<T> already borrowed', /builds/slave/mac/build/src/compiler/rust/src/libcore/cell.rs:300
13:51:41     INFO -  Pipeline failed in hard-fail mode.  Crashing!
13:51:41     INFO -  test /builds/slave/mac/build/src/test/content/test_window_setInterval.html ... FAILED
13:51:41     INFO -  test /builds/slave/mac/build/src/test/content/test_node_cloneNode.html ... ok
13:51:41     INFO -  failures:
13:51:41     INFO -  ---- /builds/slave/mac/build/src/test/content/test_window_setInterval.html stdout ----
13:51:41     INFO -     task '/builds/slave/mac/build/src/test/content/test_window_setInterval.html' failed at 'Servo exited with non-zero status Ok(exit code: 1)', /builds/slave/mac/build/src/test/harness/contenttest/contenttest.rs:130
13:51:41     INFO -  failures:
13:51:41     INFO -      /builds/slave/mac/build/src/test/content/test_window_setInterval.html

bors-servo pushed a commit that referenced this pull request Jun 11, 2014
@bors-servo bors-servo merged commit c41dd24 into servo:master Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants