-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webdriver servo async JS script breaks some wdspec tests #27031
Labels
Projects
Comments
4 tasks
bors-servo
added a commit
that referenced
this issue
Jun 22, 2020
Report exceptions for async script executions to webdriver Improving the accuracy of the async script execution for our webdriver implementation allows us to run many more webdriver tests without timeouts, which should help with web-platform-tests/wpt#24257. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #27036 and #27035 and #27031. - [x] There are tests for these changes
bors-servo
added a commit
that referenced
this issue
Jun 23, 2020
Report exceptions for async script executions to webdriver Improving the accuracy of the async script execution for our webdriver implementation allows us to run many more webdriver tests without timeouts, which should help with web-platform-tests/wpt#24257. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #27036 and #27035 and #27031. - [x] There are tests for these changes
bors-servo
added a commit
that referenced
this issue
Jun 23, 2020
Report exceptions for async script executions to webdriver Improving the accuracy of the async script execution for our webdriver implementation allows us to run many more webdriver tests without timeouts, which should help with web-platform-tests/wpt#24257. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #27036 and #27035 and #27031. - [x] There are tests for these changes
bors-servo
added a commit
that referenced
this issue
Jun 23, 2020
Report exceptions for async script executions to webdriver Improving the accuracy of the async script execution for our webdriver implementation allows us to run many more webdriver tests without timeouts, which should help with web-platform-tests/wpt#24257. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #27036 and #27035 and #27031. - [x] There are tests for these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In particular, tests/wpt/web-platform-tests/webdriver/tests/add_cookie/user_prompts.py uses:
which ends up yielding this error:
because dialog_type is a reference to the
webdriverCallback
method on Window instead of the a string like 'alert' or 'prompt'.The text was updated successfully, but these errors were encountered: